Force 'text/plain' rendering for HTML, CSS, and JS sample files.

Force 'text/plain' rendering for HTML, CSS, and JS sample files.

BUG=107548
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114533

[Mike West, 2011-12-14 16:10:50]

Hi Aaron, Kathy. As discussed earlier in the week, this change should force
sample HTML, CSS, and JavaScript to be rendered as `text/plain`. I'm not
entirely sure who should review this... Aaron?

Adam: FYI.

Thanks!

-Mike

[Aaron Boodman, 2011-12-14 21:42:12]

http://codereview.chromium.org/8942001/diff/6001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/server/chromeextensionsdocs.py (right):

http://codereview.chromium.org/8942001/diff/6001/chrome/common/extensions/doc...
chrome/common/extensions/docs/server/chromeextensionsdocs.py:82: if (path[:9] ==
"/examples" and
startswith() ?

[Mike West, 2011-12-14 21:43:00]

After chatting with Aaron a bit about the problem, I'm ham-handedly
`text/plain`ing everything under `/examples` that doesn't have a content-type
that starts with `image/`.

http://e501.muc:8080/chrome/extensions/examples/api/browserAction/set_icon_pa...
is rendered,
http://e501.muc:8080/chrome/extensions/examples/api/browserAction/set_icon_path/
is not.

In short, I don't think we should be rendering anything at all from viewvc. This
is a tiny step in that direction... I think it should be possible to simply
whitelist the bits and pieces that we want to support, but I think that's
probably a bigger discussion for another CL. If we can get this one out the
door, then Adam can start linking off to samples for the getting started
tutorial.

Thanks!

-Mike

[Mike West, 2011-12-14 21:49:02]

http://codereview.chromium.org/8942001/diff/6001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/server/chromeextensionsdocs.py (right):

http://codereview.chromium.org/8942001/diff/6001/chrome/common/extensions/doc...
chrome/common/extensions/docs/server/chromeextensionsdocs.py:82: if (path[:9] ==
"/examples" and
On 2011/12/14 21:42:15, Aaron Boodman wrote:
> startswith() ?

Learn something new every day... Using it now.

[Aaron Boodman, 2011-12-14 22:18:10]

lgtm

[kathyw, 2011-12-14 22:19:05]

The functionality looks good to me. We may change the samples page generator to
take advantage of this.

[kathyw, 2011-12-14 22:19:24]

On 2011/12/14 22:19:05, kathyw wrote:
> The functionality looks good to me. We may change the samples page generator
to
> take advantage of this.

...may *need to* change...

[commit-bot: I haz the power, 2011-12-14 22:35:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/8942001/4003

[commit-bot: I haz the power, 2011-12-15 00:02:31]

Change committed as 114533