Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: media/audio/audio_input_unittest.cc

Issue 8941001: Enable the AudioInputTest tests + Fix PCMQueueInAudioInputStream. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: address review comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/audio/mac/audio_input_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_input_unittest.cc
===================================================================
--- media/audio/audio_input_unittest.cc (revision 114391)
+++ media/audio/audio_input_unittest.cc (working copy)
@@ -88,14 +88,12 @@
};
static bool CanRunAudioTests(AudioManager* audio_man) {
- if (NULL == audio_man)
- return false;
+ bool has_input = audio_man->HasAudioInputDevices();
- scoped_ptr<base::Environment> env(base::Environment::Create());
- if (env->HasVar("CHROME_HEADLESS"))
- return false;
+ if (!has_input)
+ LOG(WARNING) << "No input devices detected";
- return audio_man->HasAudioInputDevices();
+ return has_input;
}
static AudioInputStream* CreateTestAudioInputStream(AudioManager* audio_man) {
@@ -194,10 +192,17 @@
}
// Test a recording sequence with delays in the audio callback.
+// TODO(joth): See bug 107546. This fails on slow bots. Once fixed, remove the
+// CHROME_HEADLESS check below.
TEST(AudioInputTest, RecordWithSlowSink) {
scoped_refptr<AudioManager> audio_man(AudioManager::Create());
if (!CanRunAudioTests(audio_man.get()))
return;
+
+ scoped_ptr<base::Environment> env(base::Environment::Create());
+ if (env->HasVar("CHROME_HEADLESS"))
+ return;
+
MessageLoop message_loop(MessageLoop::TYPE_DEFAULT);
AudioInputStream* ais = CreateTestAudioInputStream(audio_man.get());
EXPECT_TRUE(ais->Open());
« no previous file with comments | « no previous file | media/audio/mac/audio_input_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698