Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8941001: Enable the AudioInputTest tests + Fix PCMQueueInAudioInputStream. (Closed)

Created:
9 years ago by tommi (sloooow) - chröme
Modified:
9 years ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Enable the AudioInputTest tests on the build bots and fix a bug in PCMQueueInAudioInputStream. The tests should all succeed but on bots where audio hardware is missing, we should get a printout that no devices were detected. Notably the mac bots do have the necessary equipment which is how I ran into the bug. TEST=This runs more tests in media_unittests on the bots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114520

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M media/audio/audio_input_unittest.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M media/audio/mac/audio_input_mac.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/mac/audio_input_mac.cc View 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tommi (sloooow) - chröme
9 years ago (2011-12-14 16:10:59 UTC) #1
henrika (OOO until Aug 14)
LGTM w/ nit.
9 years ago (2011-12-14 16:16:15 UTC) #2
henrika (OOO until Aug 14)
http://codereview.chromium.org/8941001/diff/1/media/audio/mac/audio_input_mac.h File media/audio/mac/audio_input_mac.h (right): http://codereview.chromium.org/8941001/diff/1/media/audio/mac/audio_input_mac.h#newcode70 media/audio/mac/audio_input_mac.h:70: // True iff Start has been called successfully. Start()
9 years ago (2011-12-14 16:16:24 UTC) #3
tommi (sloooow) - chröme
http://codereview.chromium.org/8941001/diff/1/media/audio/mac/audio_input_mac.h File media/audio/mac/audio_input_mac.h (right): http://codereview.chromium.org/8941001/diff/1/media/audio/mac/audio_input_mac.h#newcode70 media/audio/mac/audio_input_mac.h:70: // True iff Start has been called successfully. On ...
9 years ago (2011-12-14 16:32:25 UTC) #4
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-12-14 16:33:42 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-14 23:06:41 UTC) #6 
No LGTM from valid reviewers yet.

Powered by Google App Engine
This is Rietveld 408576698