Issue 894003: Teartest with -o flag to specify override redirect window and -r number to specify refresh rate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 894003: Teartest with -o flag to specify override redirect window and -r number to specify refresh rate. (Closed)

Created:
10 years, 9 months ago by Alexey Marinichev

Modified:
9 years, 7 months ago

Reviewers:
piman

CC:
chromium-os-reviews_chromium.org, papakipos

Visibility:
Public.

Description

Teartest with -o flag to specify override redirect window and -r number to specify refresh rate.

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+167 lines, -14 lines)			Patch
M	client/deps/glbench/src/Makefile	View	1 chunk	+20 lines, -12 lines	0 comments	Download
M	client/deps/glbench/src/egl_stuff.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	client/deps/glbench/src/glx_stuff.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	client/deps/glbench/src/main.h	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	client/deps/glbench/src/shaders.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	client/deps/glbench/src/teartest.cc	View	1 chunk	+130 lines, -0 lines	2 comments	Download
M	client/deps/glbench/src/xlib_window.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

piman

LGTM after a couple of fixes http://codereview.chromium.org/894003/diff/1/7 File client/deps/glbench/src/teartest.cc (right): http://codereview.chromium.org/894003/diff/1/7#newcode70 client/deps/glbench/src/teartest.cc:70: printf("blah\n"); bleh. http://codereview.chromium.org/894003/diff/1/7#newcode111 ...

10 years, 9 months ago (2010-03-12 22:52:10 UTC) #2

Alexey Marinichev

10 years, 9 months ago (2010-03-12 22:57:36 UTC) #3

Embarrassing!  Thanks for noticing.  Checked in.

Expand Messages | Collapse Messages