Issue 8939: Backport the changes from the readability.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8939: Backport the changes from the readability. (Closed)

Created:
12 years, 1 month ago by iposva

Modified:
9 years, 4 months ago

Reviewers:
Feng Qian

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Backport the changes from the readability review. Committed: http://code.google.com/p/v8/source/detail?r=700

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+322 lines, -336 lines)			Patch
M	src/constants-arm.h	View	3 chunks	+64 lines, -38 lines	0 comments	Download
M	src/disasm.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/disasm-arm.cc	View	20 chunks	+226 lines, -278 lines	0 comments	Download
M	src/disasm-ia32.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/globals.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/simulator-arm.cc	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/v8.h	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	test/cctest/test-disasm-arm.cc	View	6 chunks	+15 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Feng Qian

12 years, 1 month ago (2008-11-04 22:05:53 UTC) #2

LGTM

http://codereview.chromium.org/8939/diff/1/3
File src/v8.h (right):

http://codereview.chromium.org/8939/diff/1/3#newcode44
Line 44: #define DEBUG
This is a big confusing. Maybe you should explain the expected build of all 4
combination in Google3.

Expand Messages | Collapse Messages