Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2282)

Issue 8938005: Fixes permissions of new files (Closed)

Created:
9 years ago by sky
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Real fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-14 lines, --14 lines) Patch
A ui/resources/aura/applist.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/aura/applist_h.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/aura/applist_p.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/aura/browser_instance_1.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/aura/browser_instance_1_h.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/aura/browser_instance_1_p.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/aura/browser_instance_2.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/aura/browser_instance_2_h.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/aura/browser_instance_2_p.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/aura/browser_instance_3.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/aura/browser_instance_3_h.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/aura/browser_instance_3_p.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/aura/launcher_overflow_h.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/aura/launcher_overflow_p.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
9 years ago (2011-12-13 18:22:49 UTC) #1
Ben Goodger (Google)
9 years ago (2011-12-13 19:18:35 UTC) #2
LGTM

On Tue, Dec 13, 2011 at 10:22 AM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Fixes permissions of new files
>
> R=ben@chromium.org
> TBR=ben@chromium.org
> BUG=none
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/8938005/<http://codereview.chromium.org/8938...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  A ui/resources/aura/applist.png
>  A ui/resources/aura/applist_h.**png
>  A ui/resources/aura/applist_p.**png
>  A ui/resources/aura/browser_**instance_1.png
>  A ui/resources/aura/browser_**instance_1_h.png
>  A ui/resources/aura/browser_**instance_1_p.png
>  A ui/resources/aura/browser_**instance_2.png
>  A ui/resources/aura/browser_**instance_2_h.png
>  A ui/resources/aura/browser_**instance_2_p.png
>  A ui/resources/aura/browser_**instance_3.png
>  A ui/resources/aura/browser_**instance_3_h.png
>  A ui/resources/aura/browser_**instance_3_p.png
>  A ui/resources/aura/launcher_**overflow_h.png
>  A ui/resources/aura/launcher_**overflow_p.png
>
>
> Index: ui/resources/aura/applist.png
> diff --git a/ui/resources/aura/applist.**png b/ui/resources/aura/applist.*
> *png
> old mode 100755
> new mode 100644
> Index: ui/resources/aura/applist_h.**png
> diff --git a/ui/resources/aura/applist_h.**png
> b/ui/resources/aura/applist_h.**png
> old mode 100755
> new mode 100644
> Index: ui/resources/aura/applist_p.**png
> diff --git a/ui/resources/aura/applist_p.**png
> b/ui/resources/aura/applist_p.**png
> old mode 100755
> new mode 100644
> Index: ui/resources/aura/browser_**instance_1.png
> diff --git a/ui/resources/aura/browser_**instance_1.png
> b/ui/resources/aura/browser_**instance_1.png
> old mode 100755
> new mode 100644
> Index: ui/resources/aura/browser_**instance_1_h.png
> diff --git a/ui/resources/aura/browser_**instance_1_h.png
> b/ui/resources/aura/browser_**instance_1_h.png
> old mode 100755
> new mode 100644
> Index: ui/resources/aura/browser_**instance_1_p.png
> diff --git a/ui/resources/aura/browser_**instance_1_p.png
> b/ui/resources/aura/browser_**instance_1_p.png
> old mode 100755
> new mode 100644
> Index: ui/resources/aura/browser_**instance_2.png
> diff --git a/ui/resources/aura/browser_**instance_2.png
> b/ui/resources/aura/browser_**instance_2.png
> old mode 100755
> new mode 100644
> Index: ui/resources/aura/browser_**instance_2_h.png
> diff --git a/ui/resources/aura/browser_**instance_2_h.png
> b/ui/resources/aura/browser_**instance_2_h.png
> old mode 100755
> new mode 100644
> Index: ui/resources/aura/browser_**instance_2_p.png
> diff --git a/ui/resources/aura/browser_**instance_2_p.png
> b/ui/resources/aura/browser_**instance_2_p.png
> old mode 100755
> new mode 100644
> Index: ui/resources/aura/browser_**instance_3.png
> diff --git a/ui/resources/aura/browser_**instance_3.png
> b/ui/resources/aura/browser_**instance_3.png
> old mode 100755
> new mode 100644
> Index: ui/resources/aura/browser_**instance_3_h.png
> diff --git a/ui/resources/aura/browser_**instance_3_h.png
> b/ui/resources/aura/browser_**instance_3_h.png
> old mode 100755
> new mode 100644
> Index: ui/resources/aura/browser_**instance_3_p.png
> diff --git a/ui/resources/aura/browser_**instance_3_p.png
> b/ui/resources/aura/browser_**instance_3_p.png
> old mode 100755
> new mode 100644
> Index: ui/resources/aura/launcher_**overflow_h.png
> diff --git a/ui/resources/aura/launcher_**overflow_h.png
> b/ui/resources/aura/launcher_**overflow_h.png
> old mode 100755
> new mode 100644
> Index: ui/resources/aura/launcher_**overflow_p.png
> diff --git a/ui/resources/aura/launcher_**overflow_p.png
> b/ui/resources/aura/launcher_**overflow_p.png
> old mode 100755
> new mode 100644
>
>
>

Powered by Google App Engine
This is Rietveld 408576698