Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: pylib/gyp/input.py

Issue 8937016: Add a test for escaping of backslashes in list expansion (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/variables/commands/commands.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/input.py
===================================================================
--- pylib/gyp/input.py (revision 1106)
+++ pylib/gyp/input.py (working copy)
@@ -736,7 +736,7 @@
output = replacement[:]
else:
# Split it the same way sh would split arguments.
- output = shlex.split(str(replacement))
+ output = shlex.split(str(replacement).replace('\\', '\\\\'))
Mark Mentovai 2011/12/14 17:53:54 Are you sure that this is right? Seems perverse. T
tony 2011/12/14 18:41:39 Backslash is only special when being passed to a c
else:
# Expanding in string context.
encoded_replacement = ''
« no previous file with comments | « no previous file | test/variables/commands/commands.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698