Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 8937003: Implement callback when script finishes running in V8 API. (Closed)

Created:
9 years ago by Yang
Modified:
8 years, 11 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Implement callback when script finishes running in V8 API. TEST=test-api/LeaveScriptCallback Committed: http://code.google.com/p/v8/source/detail?r=10323

Patch Set 1 #

Patch Set 2 : fire callbacks even when exceptions are pending. #

Patch Set 3 : s/LeaveScript/CallCompleted/g #

Patch Set 4 : Change callback list to be a static property of V8 instead of per isolate property. #

Patch Set 5 : Make call depth tracking independent from isolates. #

Patch Set 6 : clean up #

Patch Set 7 : Deal better with exceptions. #

Patch Set 8 : small fixes #

Patch Set 9 : limit callback firing sites. #

Patch Set 10 : refactor macro #

Total comments: 1

Patch Set 11 : Fixed comments. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -7 lines) Patch
M include/v8.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +18 lines, -0 lines 1 comment Download
M src/api.cc View 1 2 3 4 5 6 7 8 9 9 chunks +33 lines, -7 lines 0 comments Download
M src/execution.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.h View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 1 comment Download
M src/v8.cc View 1 2 3 4 5 6 3 chunks +39 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yang
PTAL. Suggestions for a different naming scheme are also welcome.
9 years ago (2011-12-13 12:49:15 UTC) #1
Yang
On 2011/12/13 12:49:15, Yang wrote: > PTAL. > > Suggestions for a different naming scheme ...
9 years ago (2011-12-15 10:32:57 UTC) #2
Yang
I think I might have dealt with the exception issue without too much effort. Instead ...
9 years ago (2011-12-16 12:21:08 UTC) #3
Yang
On 2011/12/16 12:21:08, Yang wrote: > I think I might have dealt with the exception ...
8 years, 11 months ago (2012-01-02 17:51:15 UTC) #4
danno
http://codereview.chromium.org/8937003/diff/14001/include/v8.h File include/v8.h (right): http://codereview.chromium.org/8937003/diff/14001/include/v8.h#newcode3046 include/v8.h:3046: * running. In case of recursive scripts, the callback ...
8 years, 11 months ago (2012-01-03 15:35:11 UTC) #5
Yang
Changed/fixed comments.
8 years, 11 months ago (2012-01-04 08:13:36 UTC) #6
danno
8 years, 11 months ago (2012-01-04 08:38:48 UTC) #7
LGTM with tiny nits

http://codereview.chromium.org/8937003/diff/19001/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/8937003/diff/19001/include/v8.h#newcode3054
include/v8.h:3054: * This function removes callback which was installed by
Just: Removes callback that was installed by AddCallCompletedCallback function

http://codereview.chromium.org/8937003/diff/19001/src/v8.h
File src/v8.h (right):

http://codereview.chromium.org/8937003/diff/19001/src/v8.h#newcode130
src/v8.h:130: // List of callbacks when a call completes.
s/call/Call

Powered by Google App Engine
This is Rietveld 408576698