Log GLenums as strings in service

Log GLenums as strings in service

TEST=none
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114516

[greggman, 2011-12-13 22:59:17]

Hi Al, please review. Thx

[apatrick_chromium, 2011-12-13 23:04:40]

lgtm

[commit-bot: I haz the power, 2011-12-14 02:39:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gman@chromium.org/8936011/5001

[commit-bot: I haz the power, 2011-12-14 03:23:14]

Try job failure for 8936011-5001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2011-12-14 05:21:52]

No LGTM from valid reviewers yet.

[greggman, 2011-12-14 05:41:32]

On 2011/12/14 05:21:52, I haz the power (commit-bot) wrote:
> No LGTM from valid reviewers y

Hey Al, I guess I need a new LGTM for some reason.

[greggman, 2011-12-14 08:44:32]

hrm,

I'm getting a circular dependency issue. See below.

I'm guessing the issue is that gpu.gyp references ui.gyp and ui.gyp not
references gpu.gyp.

I moved gles2_cmd_utils.cc to a separate gyp file
gpu/command_buffer/command_buffer.gyp. Then I made both ui.gyp and gpu.gpy
reference that. Is there an easier solution?


gyp.input.CircularException: Some files not reachable, cycle in .gyp file
dependency graph detected involving some or all of:
src/webkit/support/webkit_support.gyp src/ui/gfx/surface/surface.gyp
src/gpu/gles2_conform_support/gles2_conform_support.gyp src/ui/gfx/gl/gl.gyp
src/third_party/WebKit/Source/WebCore/WebCore.gyp/WebCore.gyp
src/webkit/webkit.gyp src/gpu/demos/demos.gyp
src/chrome/default_plugin/default_plugin.gyp
src/third_party/WebKit/Source/WebKit/chromium/WebKit.gyp
src/remoting/remoting.gyp src/build/all.gyp src/chrome/chrome_resources.gyp
src/ui/gfx/compositor/compositor.gyp src/gpu/gpu.gyp
src/third_party/gles2_book/gles2_book.gyp src/chrome/chrome.gyp
src/content/content.gyp src/chrome/browser/sync/tools/sync_tools.gyp
src/ppapi/ppapi_internal.gyp

[M-A Ruel, 2011-12-14 15:03:08]

On 2011/12/14 05:21:52, I haz the power (commit-bot) wrote:
> No LGTM from valid reviewers yet.

Sorry for the annoyance, bug is now fixed.

Because of greggman's message, I didn't check the commit bit. It's now safe to
use again.

[apatrick_chromium, 2011-12-14 19:28:51]

On 2011/12/14 08:44:32, greggman wrote:
> hrm,
> 
> I'm getting a circular dependency issue. See below.
> 
> I'm guessing the issue is that gpu.gyp references ui.gyp and ui.gyp not
> references gpu.gyp.
> 
> I moved gles2_cmd_utils.cc to a separate gyp file
> gpu/command_buffer/command_buffer.gyp. Then I made both ui.gyp and gpu.gpy
> reference that. Is there an easier solution?
> 
> 
> gyp.input.CircularException: Some files not reachable, cycle in .gyp file
> dependency graph detected involving some or all of:
> src/webkit/support/webkit_support.gyp src/ui/gfx/surface/surface.gyp
> src/gpu/gles2_conform_support/gles2_conform_support.gyp src/ui/gfx/gl/gl.gyp
> src/third_party/WebKit/Source/WebCore/WebCore.gyp/WebCore.gyp
> src/webkit/webkit.gyp src/gpu/demos/demos.gyp
> src/chrome/default_plugin/default_plugin.gyp
> src/third_party/WebKit/Source/WebKit/chromium/WebKit.gyp
> src/remoting/remoting.gyp src/build/all.gyp src/chrome/chrome_resources.gyp
> src/ui/gfx/compositor/compositor.gyp src/gpu/gpu.gyp
> src/third_party/gles2_book/gles2_book.gyp src/chrome/chrome.gyp
> src/content/content.gyp src/chrome/browser/sync/tools/sync_tools.gyp
> src/ppapi/ppapi_internal.gyp

Sorry I missed that. It would be fine to move GLES2Util::GetStringEnum into
ui/gfx/gl. Or does it get compiled into NaCl as well?

[greggman, 2011-12-14 19:45:34]

On 2011/12/14 19:28:51, apatrick_chromium wrote:
> On 2011/12/14 08:44:32, greggman wrote:
> > hrm,
> > 
> > I'm getting a circular dependency issue. See below.
> > 
> > I'm guessing the issue is that gpu.gyp references ui.gyp and ui.gyp not
> > references gpu.gyp.
> > 
> > I moved gles2_cmd_utils.cc to a separate gyp file
> > gpu/command_buffer/command_buffer.gyp. Then I made both ui.gyp and gpu.gpy
> > reference that. Is there an easier solution?
> > 
> > 
> > gyp.input.CircularException: Some files not reachable, cycle in .gyp file
> > dependency graph detected involving some or all of:
> > src/webkit/support/webkit_support.gyp src/ui/gfx/surface/surface.gyp
> > src/gpu/gles2_conform_support/gles2_conform_support.gyp src/ui/gfx/gl/gl.gyp
> > src/third_party/WebKit/Source/WebCore/WebCore.gyp/WebCore.gyp
> > src/webkit/webkit.gyp src/gpu/demos/demos.gyp
> > src/chrome/default_plugin/default_plugin.gyp
> > src/third_party/WebKit/Source/WebKit/chromium/WebKit.gyp
> > src/remoting/remoting.gyp src/build/all.gyp src/chrome/chrome_resources.gyp
> > src/ui/gfx/compositor/compositor.gyp src/gpu/gpu.gyp
> > src/third_party/gles2_book/gles2_book.gyp src/chrome/chrome.gyp
> > src/content/content.gyp src/chrome/browser/sync/tools/sync_tools.gyp
> > src/ppapi/ppapi_internal.gyp
> 
> Sorry I missed that. It would be fine to move GLES2Util::GetStringEnum into
> ui/gfx/gl. Or does it get compiled into NaCl as well?

I'm in the process of using it in NaCl.

[apatrick_chromium, 2011-12-14 20:29:50]

> > Sorry I missed that. It would be fine to move GLES2Util::GetStringEnum into
> > ui/gfx/gl. Or does it get compiled into NaCl as well?
> 
> I'm in the process of using it in NaCl.

Making something in gl.gyp depend on something in gpu.gyp is a bit weird but it
doesn't break deps and it'll be messy making NaCl depend on something outside of
gpu.gyp as well so I guess LGTM.

[commit-bot: I haz the power, 2011-12-14 21:45:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gman@chromium.org/8936011/17005

[commit-bot: I haz the power, 2011-12-14 23:03:37]

Change committed as 114516