Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 8936009: Check for the specific interface versions required in pp::Var. (Closed)

Created:
9 years ago by Wez
Modified:
8 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Check for the specific interface versions required in pp::Var. BUG=107398 TEST=Plugins built with Pepper 17 SDK should be able to use pp::Var::AsString() even when run under Pepper 15. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116540

Patch Set 1 #

Patch Set 2 : Add missing interface_name<PPB_Var_1_1>() definition. #

Patch Set 3 : Remove unused interface_name<PPB_Var> definition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ppapi/cpp/var.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Wez
This CL fixes pp::Var to use versioned interface checks; I think it makes sense for ...
9 years ago (2011-12-13 19:54:51 UTC) #1
brettw
lgtm
9 years ago (2011-12-13 19:57:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/8936009/1
9 years ago (2011-12-13 20:10:37 UTC) #3
commit-bot: I haz the power
Try job failure for 8936009-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-13 20:32:56 UTC) #4
Wez
On 2011/12/13 20:32:56, I haz the power (commit-bot) wrote: > Try job failure for 8936009-1 ...
9 years ago (2011-12-13 22:34:14 UTC) #5
brettw
I don't really understand what you're saying here.
9 years ago (2011-12-13 22:54:18 UTC) #6
Wez
On 2011/12/13 22:54:18, brettw wrote: > I don't really understand what you're saying here. PPB_Var ...
9 years ago (2011-12-13 23:07:31 UTC) #7
Wez
PTAL!
8 years, 11 months ago (2012-01-05 16:44:37 UTC) #8
dmichael (off chromium)
lgtm
8 years, 11 months ago (2012-01-05 18:19:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/8936009/10001
8 years, 11 months ago (2012-01-05 18:34:39 UTC) #10
commit-bot: I haz the power
8 years, 11 months ago (2012-01-05 20:40:31 UTC) #11
Change committed as 116540

Powered by Google App Engine
This is Rietveld 408576698