Issue 8936004: Avoid using an invalid working directory in mjsunit/d8-os.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8936004: Avoid using an invalid working directory in mjsunit/d8-os. (Closed)

Created:
9 years ago by kalmard

Modified:
9 years ago

Reviewers:
kisg, Paul Lind, Vitaly Repeshko, danno

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

Avoid using an invalid working directory in mjsunit/d8-os. This test deleted its working directory and then tried to run several shell commands which caused a failure on nfs. Changes: -TEST_DIR is only removed at the very end of the test -the working directory is changed to /tmp at the beginning so that every iteration (when running with --stress-opt) has a valid working directory BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10240

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -35 lines)			Patch
	M	test/mjsunit/d8-os.js	View		2 chunks	+38 lines, -35 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2011/12/13 09:43:32, kalmard wrote:

LGTM and landing.

Expand Messages | Collapse Messages