Issue 8936002: DISABLE media_unittests:CompositeFilterDeathTest.DISABLED_TestRemoveUnknownFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8936002: DISABLE media_unittests:CompositeFilterDeathTest.DISABLED_TestRemoveUnknownFilter. (Closed)

Created:
9 years ago by Ami GONE FROM CHROMIUM

Modified:
9 years ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DISABLE media_unittests:CompositeFilterDeathTest.DISABLED_TestRemoveUnknownFilter. This'll be revived or deleted shortly. BUG=104579 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114184

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	media/base/composite_filter_unittest.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

lgtm http://codereview.chromium.org/8936002/diff/1/media/base/composite_filter_unittest.cc File media/base/composite_filter_unittest.cc (right): http://codereview.chromium.org/8936002/diff/1/media/base/composite_filter_unittest.cc#newcode399 media/base/composite_filter_unittest.cc:399: // TODO(fischman): figure out why this is flaky. ...

9 years ago (2011-12-13 05:59:39 UTC) #1

Ami GONE FROM CHROMIUM

9 years ago (2011-12-13 06:05:46 UTC) #2

Thanks!

http://codereview.chromium.org/8936002/diff/1/media/base/composite_filter_uni...
File media/base/composite_filter_unittest.cc (right):

http://codereview.chromium.org/8936002/diff/1/media/base/composite_filter_uni...
media/base/composite_filter_unittest.cc:399: // TODO(fischman): figure out why
this is flaky.
On 2011/12/13 05:59:40, Ryan Sleevi wrote:
> nit: Note the bug # in the comment, as per
>
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/han...

Done.

Expand Messages | Collapse Messages