Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: chrome/browser/extensions/extension_menu_manager.h

Issue 8935016: Contributed by Eriq Augustine <eriq.augustine@gmail.com> (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_menu_manager.h
===================================================================
--- chrome/browser/extensions/extension_menu_manager.h (revision 116264)
+++ chrome/browser/extensions/extension_menu_manager.h (working copy)
@@ -239,6 +239,12 @@
// Returns the item with the given |id| or NULL.
ExtensionMenuItem* GetItemById(const ExtensionMenuItem::Id& id) const;
+ // Notify the ExtensionMenuManager that an item has been updated not through
+ // an explicit call into ExtensionMenuManager. For example, if an item is
+ // acquired by a call to GetItemById and changed, then this should be called.
+ // Returns true if the item was found or false otherwise.
+ bool ItemUpdated(const ExtensionMenuItem::Id& id);
+
// Called when a menu item is clicked on by the user.
void ExecuteCommand(Profile* profile, content::WebContents* web_contents,
const ContextMenuParams& params,
@@ -261,6 +267,12 @@
// items in the same group (i.e. that are adjacent in the list).
void RadioItemSelected(ExtensionMenuItem* item);
+ // Make sure that there is only one radio item selected at once in any run.
+ // If there are no radio items selected, then the first item in the run
+ // will get selected. If there are multiple radio items selected, then only
+ // the last one will get selcted.
+ void SanitizeRadioList(const ExtensionMenuItem::List& item_list);
asargent_no_longer_on_chrome 2012/01/06 21:17:42 Since you potentially modify some of |item_list|'s
+
// Returns true if item is a descendant of an item with id |ancestor_id|.
bool DescendantOf(ExtensionMenuItem* item,
const ExtensionMenuItem::Id& ancestor_id);

Powered by Google App Engine
This is Rietveld 408576698