Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3157)

Unified Diff: chrome/browser/extensions/extension_menu_manager.h

Issue 8935016: Contributed by Eriq Augustine <eriq.augustine@gmail.com> (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_menu_manager.h
===================================================================
--- chrome/browser/extensions/extension_menu_manager.h (revision 114114)
+++ chrome/browser/extensions/extension_menu_manager.h (working copy)
@@ -250,6 +250,10 @@
virtual void Observe(int type, const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
+ // Sanitize radio buttons so that and run of radio buttons does not
asargent_no_longer_on_chrome 2011/12/15 18:38:40 typo: "and run" -> "a run"
+ // enter a state where none are checked.
+ void SanitizeRadioButtons();
+
private:
FRIEND_TEST_ALL_PREFIXES(ExtensionMenuManagerTest, DeleteParent);
FRIEND_TEST_ALL_PREFIXES(ExtensionMenuManagerTest, RemoveOneByOne);
@@ -262,6 +266,10 @@
bool DescendantOf(ExtensionMenuItem* item,
const ExtensionMenuItem::Id& ancestor_id);
+ // Recursivly looks for a run of radio items. If on is found that
asargent_no_longer_on_chrome 2011/12/15 18:38:40 typo: "Recursivly" -> "Recursively" typo: "If on"
+ // does not have any selected item, select the first one.
+ void RecursiveSanitizeRadioButtons(const ExtensionMenuItem::List& item_list);
+
// We keep items organized by mapping an extension id to a list of items.
typedef std::map<std::string, ExtensionMenuItem::List> MenuItemMap;
MenuItemMap context_items_;

Powered by Google App Engine
This is Rietveld 408576698