Contributed by Eriq Augustine <eriq.augustine@gmail.com>

chrome/browser/extensions/extension_context_menu_api.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_context_menu_api.h"
 
 #include <string>
 
 #include "base/values.h"
 #include "base/string_number_conversions.h"
@@ skipping 251 matching lines @@
     success = menu_manager->AddContextItem(GetExtension(), item.release());
   }
 
   if (!success)
     return false;
 
   return true;
 }
 
 bool UpdateContextMenuFunction::RunImpl() {
+  bool radioItemUpdated = false;
   ExtensionMenuItem::Id item_id(profile(), extension_id(), 0);
   EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &item_id.uid));
 
   ExtensionService* service = profile()->GetExtensionService();
   ExtensionMenuManager* manager = service->menu_manager();
   ExtensionMenuItem* item = manager->GetItemById(item_id);
   if (!item || item->extension_id() != extension_id()) {
     error_ = ExtensionErrorUtils::FormatErrorMessage(
         kCannotFindItemError, base::IntToString(item_id.uid));
     return false;
   }
 
-  DictionaryValue *properties = NULL;
+  DictionaryValue* properties = NULL;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(1, &properties));
   EXTENSION_FUNCTION_VALIDATE(properties != NULL);
 
-  ExtensionMenuManager* menu_manager =
-      profile()->GetExtensionService()->menu_manager();
-
   // Type.
   ExtensionMenuItem::Type type;
   if (!ParseType(*properties, item->type(), &type))
     return false;
-  if (type != item->type())
+  if (type != item->type()) {
+    if (type == ExtensionMenuItem::RADIO ||
+        item->type() == ExtensionMenuItem::RADIO) {
+      radioItemUpdated = true;
+    }
     item->set_type(type);
+  }
 
   // Title.
   if (properties->HasKey(kTitleKey)) {
     std::string title;
     EXTENSION_FUNCTION_VALIDATE(properties->GetString(kTitleKey, &title));
     if (title.empty() && type != ExtensionMenuItem::SEPARATOR) {
       error_ = kTitleNeededError;
       return false;
     }
     item->set_title(title);
   }
 
   // Checked state.
   bool checked;
   if (!ParseChecked(item->type(), *properties, item->checked(), &checked))
     return false;
   if (checked != item->checked()) {
     if (!item->SetChecked(checked))
       return false;
+    radioItemUpdated = true;
   }
 
   // Contexts.
   ExtensionMenuItem::ContextList contexts(item->contexts());
   if (!ParseContexts(*properties, kContextsKey, &contexts))
     return false;
   if (contexts != item->contexts())
     item->set_contexts(contexts);
 
   // Parent id.
   ExtensionMenuItem* parent = NULL;
-  if (!GetParent(*properties, *menu_manager, &parent))
+  if (!GetParent(*properties, *manager, &parent))
     return false;
-  if (parent && !menu_manager->ChangeParent(item->id(), &parent->id()))
+  if (parent && !manager->ChangeParent(item->id(), &parent->id()))
     return false;
 
   if (!SetURLPatterns(*properties, item))
     return false;
 
+  // There is no need to call ItemUpdated if ChangeParent is called because
+  // all sanitation is taken care of in ChangeParent.
+  if (!parent && radioItemUpdated && !manager->ItemUpdated(item->id()))
+    return false;
+
   return true;
 }
 
 bool RemoveContextMenuFunction::RunImpl() {
   ExtensionMenuItem::Id id(profile(), extension_id(), 0);
   EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &id.uid));
   ExtensionService* service = profile()->GetExtensionService();
   ExtensionMenuManager* manager = service->menu_manager();
 
   ExtensionMenuItem* item = manager->GetItemById(id);
   // Ensure one extension can't remove another's menu items.
   if (!item || item->extension_id() != extension_id()) {
     error_ = ExtensionErrorUtils::FormatErrorMessage(
         kCannotFindItemError, base::IntToString(id.uid));
     return false;
   }
 
   return manager->RemoveContextMenuItem(id);
 }
 
 bool RemoveAllContextMenusFunction::RunImpl() {
   ExtensionService* service = profile()->GetExtensionService();
   ExtensionMenuManager* manager = service->menu_manager();
   manager->RemoveAllContextItems(extension_id());
   return true;
 }