Contributed by Eriq Augustine <eriq.augustine@gmail.com>

chrome/browser/extensions/extension_menu_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/json/json_reader.h"
 #include "base/memory/scoped_vector.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
@@ skipping 233 matching lines @@
 
   const ExtensionMenuItem::List* items =
       manager_.MenuItems(item1->extension_id());
   ASSERT_EQ(2u, items->size());
   ASSERT_EQ(item1, items->at(0));
   ASSERT_EQ(item2, items->at(1));
 
   // Now create a third item, initially add it as a child of item1, then move
   // it to be a child of item2.
   ExtensionMenuItem* item3 = CreateTestItem(extension1);
-
   ASSERT_TRUE(manager_.AddChildItem(item1->id(), item3));
   ASSERT_EQ(1, item1->child_count());
   ASSERT_EQ(item3, item1->children()[0]);
 
   ASSERT_TRUE(manager_.ChangeParent(item3->id(), &item2->id()));
   ASSERT_EQ(0, item1->child_count());
   ASSERT_EQ(1, item2->child_count());
   ASSERT_EQ(item3, item2->children()[0]);
 
   // Move item2 to be a child of item1.
@@ skipping 221 matching lines @@
   ASSERT_EQ(params.page_url.spec(), tmp);
 
   string16 tmp16;
   ASSERT_TRUE(info->GetString("selectionText", &tmp16));
   ASSERT_EQ(params.selection_text, tmp16);
 
   bool bool_tmp = true;
   ASSERT_TRUE(info->GetBoolean("editable", &bool_tmp));
   ASSERT_EQ(params.is_editable, bool_tmp);
 }
+
+// Test that SanitizeRadioButtons will always leave a run of
+// radio buttons with one item selected.
+TEST_F(ExtensionMenuManagerTest, SanitizeRadioButtons) {
+  Extension* extension = AddExtension("test");
+
+  // A single unchecked item should get checked
+  ExtensionMenuItem* item1 = CreateTestItem(extension);
+
+  manager_.AddContextItem(extension, item1);
+  item1->set_type(ExtensionMenuItem::RADIO);
+  item1->SetChecked(false);
+  ASSERT_FALSE(item1->checked());
+  manager_.SanitizeRadioButtons();
+  ASSERT_TRUE(item1->checked());
+
+  // In a run of two unchecked items, the first should get selected.
+  item1->SetChecked(false);
+  ExtensionMenuItem* item2 = CreateTestItem(extension);
+  item2->set_type(ExtensionMenuItem::RADIO);
+  item2->SetChecked(false);
+  manager_.AddContextItem(extension, item2);
+  ASSERT_FALSE(item1->checked());
+  ASSERT_FALSE(item2->checked());
+  manager_.SanitizeRadioButtons();
+  ASSERT_TRUE(item1->checked());
+  ASSERT_FALSE(item2->checked());
+
+  // If multiple items are checked, only the last item should get checked.
+  item1->SetChecked(true);
+  item2->SetChecked(true);
+  ASSERT_TRUE(item1->checked());
+  ASSERT_TRUE(item2->checked());
+  manager_.SanitizeRadioButtons();
+  ASSERT_FALSE(item1->checked());
+  ASSERT_TRUE(item2->checked());
+
+  // If the checked item is removed, the new first item should get checked.
+  item1->SetChecked(false);
+  item2->SetChecked(true);
+  ASSERT_FALSE(item1->checked());
+  ASSERT_TRUE(item2->checked());
+  manager_.RemoveContextMenuItem(item2->id());
+  manager_.SanitizeRadioButtons();
+  ASSERT_TRUE(item1->checked());
+
+  // If a checked item is added to a run that already has a checked item,
+  // then the new item should get checked.
+  item1->SetChecked(true);
+  ExtensionMenuItem* newItem = CreateTestItem(extension);
+  newItem->set_type(ExtensionMenuItem::RADIO);
+  newItem->SetChecked(true);
+  ASSERT_TRUE(item1->checked());
+  ASSERT_TRUE(newItem->checked());
+  manager_.AddContextItem(extension, newItem);
+  manager_.SanitizeRadioButtons();
+  ASSERT_FALSE(item1->checked());
+  ASSERT_TRUE(newItem->checked());
+}
+
+

[Aaron Boodman, 2011/12/15 00:53:55]

Remove extra blank lines. There should be exactly one '\n' at the end of the
file.