Create the SDK in dart-sdk directory. The sdk zip file's contents

tools/upload_sdk.py

Index: tools/upload_sdk.py
===================================================================
--- tools/upload_sdk.py	(revision 2391)
+++ tools/upload_sdk.py	(working copy)
@@ -5,13 +5,17 @@
 # found in the LICENSE file.
 
 # This zips the SDK and uploads it to Google Storage when run on a buildbot.
+#
+# Usage: upload_sdk.py path_to_sdk
 
 import os
 import subprocess
 import sys
 import utils
 
+from os.path import basename, dirname, join

[Siggi Cherem (dart-lang), 2011/12/13 19:01:00]

I personally like how this looks in the code, but I think our style guide
requires using os.path.X in the code instead.

[dgrove, 2011/12/13 22:38:41]

Done.

 
+
 GSUTIL = '/b/build/scripts/slave/gsutil'
 GS_SITE = 'gs://'
 GS_DIR = 'dart-dump-render-tree'
@@ -75,14 +79,17 @@
   if revision is None:
     sys.stderr.write('Unable to find SVN revision.\n')
     return 1
-  os.chdir(argv[1])
+  os.chdir(dirname(argv[1]))
+  revision_file = open(join(basename(argv[1]), 'revision'), 'w')
+  revision_file.write(revision + '\n')
+  revision_file.close()

[Siggi Cherem (dart-lang), 2011/12/13 19:01:00]

(nit): slightly better style:
with open(join(basename(argv[1]), 'revision'), 'w') as f:
  f.write(revision + '\n')

(close is done automatically, even if an exception is thrown)

[dgrove, 2011/12/13 22:38:41]

Done.

+
   # TODO(dgrove) - deal with architectures that are not ia32.
-  sdk_name = 'dart-' + utils.GuessOS() + '-' + revision + '.zip'
-  sdk_file = '../' + sdk_name
-  ExecuteCommand(['zip', '-yr', sdk_file, '.'])
-  UploadArchive(sdk_file, GS_SITE + os.path.join(gsdir, SDK, sdk_name))
+  sdk_file = 'dart-' + utils.GuessOS() + '-' + revision + '.zip'

[Siggi Cherem (dart-lang), 2011/12/13 19:01:00]

(style nit):
sdk_file = 'dart-%s-%s.zip' % (utils.GuessOS(), revision)

+  ExecuteCommand(['zip', '-yr', sdk_file, basename(argv[1])])
+  UploadArchive(sdk_file, GS_SITE + join(gsdir, SDK, sdk_file))
   latest_name = 'dart-' + utils.GuessOS() + '-latest' + '.zip'
-  UploadArchive(sdk_file, GS_SITE + os.path.join(gsdir, SDK, latest_name))
+  UploadArchive(sdk_file, GS_SITE + join(gsdir, SDK, latest_name))
 
 
 if __name__ == '__main__':