Un-DISABLE media_unittests:CompositeFilterDeathTest.TestRemoveUnknownFilter.

s/NOTREACHED/LOG(FATAL)/ to die even in release builds.

BUG=104579
TEST=built Debug & Release on desktop and verified test passes (after failing in Release on desktop before the change to RemoveFilter).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114193

[Ami GONE FROM CHROMIUM, 2011-12-13 06:23:09]

scherkus: please review
rsleevi: FYI atoning for my sins.

[scherkus (not reviewing), 2011-12-13 06:49:37]

lgtm
On Dec 12, 2011 10:23 PM, <fischman@chromium.org> wrote:

> Reviewers: scherkus,
>
> Message:
> scherkus: please review
> rsleevi: FYI atoning for my sins.
>
> Description:
> s/NOTREACHED/LOG(FATAL)/ to die even in release builds.
>
> BUG=104579
> TEST=built Debug & Release on desktop and verified test passes (after
> failing in
> Release on desktop before the change to RemoveFilter).
>
>
> Please review this at
http://codereview.chromium.**org/8934002/<http://codereview.chromium.org/8934...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M media/base/composite_filter.cc
>  M media/base/composite_filter_**unittest.cc
>
>
> Index: media/base/composite_filter.cc
> diff --git a/media/base/composite_filter.**cc
> b/media/base/composite_filter.**cc
> index 0b9e87e43a81836c3409bacf69178b**16b3d170cd..**
> 191280b96c394ed8f1ed9601131cfb**fbcdccba19 100644
> --- a/media/base/composite_filter.**cc
> +++ b/media/base/composite_filter.**cc
> @@ -82,7 +82,7 @@ void CompositeFilter::RemoveFilter(**scoped_refptr<Filter>
> filter) {
>     filter->clear_host();
>     return;
>   }
> -  NOTREACHED() << "Filter missing.";
> +  LOG(FATAL) << "Filter missing.";
>  }
>
>  void CompositeFilter::set_host(**FilterHost* host) {
> Index: media/base/composite_filter_**unittest.cc
> diff --git a/media/base/composite_filter_**unittest.cc
> b/media/base/composite_filter_**unittest.cc
> index fc75ce2391c3759dae6351359be4fe**3db285924c..**
> 6b7f219555871378c52394a5f76192**148823b6c4 100644
> --- a/media/base/composite_filter_**unittest.cc
> +++ b/media/base/composite_filter_**unittest.cc
> @@ -396,8 +396,7 @@ TEST_F(CompositeFilterTest, TestAddRemoveFilter) {
>  class CompositeFilterDeathTest : public CompositeFilterTest {};
>
>  // Test failure of RemoveFilter() on an unknown filter.
> -// TODO(fischman): figure out why this is flaky.  http://crbug.com/104579
> -TEST_F(**CompositeFilterDeathTest, DISABLED_**TestRemoveUnknownFilter) {
> +TEST_F(**CompositeFilterDeathTest, TestRemoveUnknownFilter) {
>   composite_->set_host(mock_**filter_host_.get());
>   // Remove unknown filter.
>   scoped_refptr<StrictMock<**MockFilter> > filter = new
> StrictMock<MockFilter>();
>
>
>

[commit-bot: I haz the power, 2011-12-13 06:51:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/8934002/1

[commit-bot: I haz the power, 2011-12-13 08:29:08]

Change committed as 114193