Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 8933025: Reverting half the checkins that are suspected of breaking the world. (Closed)

Created:
9 years ago by Finnur
Modified:
9 years ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews
Visibility:
Public.

Description

Reverting half the checkins that are suspected of breaking the world. Revert 114384 - Var keeps invalid var_id if VarTracker release it and there is another reference. When VarTracker remove PP_Var from VarMap, it release its Var object if needed, but never reset var_id stored in Var object. Then, if Var's reference count is not 1, Var continue to exist with invalid var_id until the last reference is released. BUG=87310 TEST=ui_tests --gtest_filter='PPAPITest.WebSocket_*' Review URL: http://codereview.chromium.org/8872065 TBR=toyoshim@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M ppapi/shared_impl/var.h View 3 chunks +0 lines, -6 lines 0 comments Download
M ppapi/shared_impl/var_tracker.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
9 years ago (2011-12-14 10:05:40 UTC) #1
Takashi Toyoshima
9 years ago (2011-12-14 12:59:39 UTC) #2
LGTM.
This change must break the waterfall because RsetVarID() which I added
cause an unexpected DCHECK failure.
I must notice this problem before landing.
Sorry for inconvenience and thank you for handling this revert.

Powered by Google App Engine
This is Rietveld 408576698