Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 8933019: Fix harmless warning in setup_third_party (Closed)

Created:
9 years ago by Dirk Pranke
Modified:
9 years ago
Reviewers:
tony
CC:
chromium-reviews
Visibility:
Public.

Description

Fix harmless warning in setup_third_party that was causing all of the forwarding headers for webkit to be reported as missing. R=tony@chromium.org BUG=107444 TEST="missing file" warnings gone from build.webkit.org win bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114519

Patch Set 1 #

Patch Set 2 : fix patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webkit/support/setup_third_party.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
9 years ago (2011-12-14 00:02:18 UTC) #1
tony
I agree that the warning is harmless, but it's a bug in gyp. I posted ...
9 years ago (2011-12-14 00:13:13 UTC) #2
Dirk Pranke
Oh, okay. -- Dirk On Tue, Dec 13, 2011 at 4:13 PM, <tony@chromium.org> wrote: > ...
9 years ago (2011-12-14 00:14:21 UTC) #3
tony
Mark tells me that this behavior is intentional. Another option is to single quote each ...
9 years ago (2011-12-14 19:45:00 UTC) #4
Dirk Pranke
9 years ago (2011-12-14 23:01:34 UTC) #5
On 2011/12/14 19:45:00, tony wrote:
> Mark tells me that this behavior is intentional.  Another option is to single
> quote each filename.  Replacing with forward slash seems fine too.  In either
> case, this deserves a comment.
> 
> With a comment, LGTM

Okay, will add a comment and land.

Powered by Google App Engine
This is Rietveld 408576698