Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 8933012: Revert "Extract common code from StringPiece and StringPiece16 into a templated base class.... (Closed)

Created:
9 years ago by erikwright (departed)
Modified:
9 years ago
Reviewers:
CC:
chromium-reviews, Paweł Hajdan Jr., jshin+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert "Extract common code from StringPiece and StringPiece16 into a templated base class.... ... Convert copy-and-pasted unit tests into TYPED_TESTs." This reverts commit 20543ba53ab8737affb06a21149c15f772246aed. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -339 lines) Patch
M base/i18n/case_conversion.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/logging.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/string_piece.h View 5 chunks +132 lines, -126 lines 0 comments Download
M base/string_piece.cc View 12 chunks +19 lines, -36 lines 0 comments Download
M base/string_piece_unittest.cc View 7 chunks +292 lines, -173 lines 0 comments Download
M base/utf_offset_string_conversions.h View 1 chunk +5 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698