Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 8933010: Wires up new launcher images. To get the official images for the (Closed)

Created:
9 years ago by sky
Modified:
9 years ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Wires up new launcher images. To get the official images for the launcher I routed obtaining the id through the shell delegate (since it lives in chrome). BUG=105900 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114373

Patch Set 1 #

Patch Set 2 : Add comment #

Patch Set 3 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -86 lines) Patch
M chrome/browser/ui/views/aura/chrome_shell_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/aura/chrome_shell_delegate.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/aura_shell/examples/aura_shell_main.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/aura_shell/launcher/launcher_view.cc View 4 chunks +20 lines, -49 lines 0 comments Download
M ui/aura_shell/launcher/tabbed_launcher_button.h View 1 4 chunks +15 lines, -8 lines 0 comments Download
M ui/aura_shell/launcher/tabbed_launcher_button.cc View 3 chunks +44 lines, -28 lines 0 comments Download
M ui/aura_shell/shell_delegate.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/aura_shell/test/test_shell_delegate.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura_shell/test/test_shell_delegate.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
9 years ago (2011-12-13 19:15:41 UTC) #1
Ben Goodger (Google)
lgtm
9 years ago (2011-12-13 19:19:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/8933010/2001
9 years ago (2011-12-13 21:31:33 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-13 22:26:26 UTC) #4
Try job failure for 8933010-2001 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698