Issue 8933010: Wires up new launcher images. To get the official images for the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8933010: Wires up new launcher images. To get the official images for the (Closed)

Created:
9 years ago by sky

Modified:
9 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Wires up new launcher images. To get the official images for the launcher I routed obtaining the id through the shell delegate (since it lives in chrome). BUG=105900 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114373

Patch Set 1 #

Patch Set 2 : Add comment #

Patch Set 3 : Fix compile #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -86 lines)			Patch
M	chrome/browser/ui/views/aura/chrome_shell_delegate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/aura/chrome_shell_delegate.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/aura_shell/examples/aura_shell_main.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher_view.cc	View		4 chunks	+20 lines, -49 lines	0 comments	Download
M	ui/aura_shell/launcher/tabbed_launcher_button.h	View	1	4 chunks	+15 lines, -8 lines	0 comments	Download
M	ui/aura_shell/launcher/tabbed_launcher_button.cc	View		3 chunks	+44 lines, -28 lines	0 comments	Download
M	ui/aura_shell/shell_delegate.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	ui/aura_shell/test/test_shell_delegate.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura_shell/test/test_shell_delegate.cc	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/8933010/2001

9 years ago (2011-12-13 21:31:33 UTC) #3

commit-bot: I haz the power

9 years ago (2011-12-13 22:26:26 UTC) #4

Try job failure for 8933010-2001 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages