Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 8932013: Change the key binding of toggling caps lock on the keyboard overlay. (Closed)

Created:
9 years ago by mazda
Modified:
9 years ago
CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org
Visibility:
Public.

Description

Change the key binding of toggling caps lock on the keyboard overlay. Also fix a typo in es_419 data. BUG=chromium-os:23036 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mazda
9 years ago (2011-12-14 07:28:35 UTC) #1
Yusuke Sato
On 2011/12/14 07:28:35, mazda wrote: lgtm, thanks!
9 years ago (2011-12-14 07:36:06 UTC) #2
Daniel Erat
lgtm
9 years ago (2011-12-14 15:56:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/8932013/1
9 years ago (2011-12-14 16:22:34 UTC) #4
commit-bot: I haz the power
Presubmit check for 8932013-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-14 16:22:37 UTC) #5
mazda
Xiyuan, Could you take a look for OWNER's approval?
9 years ago (2011-12-14 16:49:09 UTC) #6
xiyuan
jhawkins/estade, Could you stamp on this?
9 years ago (2011-12-14 17:37:25 UTC) #7
xiyuan
LGTM Never mind. Just found out that I could stamp on this. Yay! :)
9 years ago (2011-12-14 17:39:18 UTC) #8
mazda
On 2011/12/14 17:39:18, xiyuan wrote: > LGTM > > Never mind. Just found out that ...
9 years ago (2011-12-14 17:41:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/8932013/1
9 years ago (2011-12-14 17:42:43 UTC) #10
commit-bot: I haz the power
9 years ago (2011-12-14 18:45:01 UTC) #11
Change committed as 114461

Powered by Google App Engine
This is Rietveld 408576698