Issue 8932006: Revert "Redo r113722 - Add Pass(), which implements move semantics, to scoped_ptr, scoped_array...."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8932006: Revert "Redo r113722 - Add Pass(), which implements move semantics, to scoped_ptr, scoped_array...." (Closed)

Created:
9 years ago by awong

Modified:
9 years ago

Reviewers:
kareng

CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, Paweł Hajdan Jr., mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Redo r113722 - Add Pass(), which implements move semantics, to scoped_ptr, scoped_array...." This reverts commit r113922. Win Canary has been failing to link due to OOM since the weekend. While this was not the original cause, it might be making things worse. Speculatively remove for now. BUG=none TEST=none TBR=kareng Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114228

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+163 lines, -653 lines)			Patch
M	base/bind_helpers.h	View	8 chunks	+31 lines, -121 lines	0 comments	Download
M	base/bind_internal.h	View	78 chunks	+78 lines, -189 lines	0 comments	Download
M	base/bind_internal.h.pump	View	8 chunks	+8 lines, -7 lines	0 comments	Download
M	base/bind_unittest.cc	View	5 chunks	+5 lines, -62 lines	0 comments	Download
M	base/callback.h	View	7 chunks	+28 lines, -28 lines	0 comments	Download
M	base/callback.h.pump	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/callback_internal.h	View	2 chunks	+0 lines, -59 lines	0 comments	Download
M	base/memory/scoped_ptr.h	View	10 chunks	+12 lines, -81 lines	0 comments	Download
M	base/memory/scoped_ptr_unittest.cc	View	2 chunks	+0 lines, -92 lines	0 comments	Download
M	chrome/common/extensions/extension_manifests_unittest.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages