Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 8931025: Handle external strings in generated code when concatenating short strings. (Closed)

Created:
9 years ago by Yang
Modified:
9 years ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Handle external strings in generated code when concatenating short strings. TEST=string-external-cached.js Committed: http://code.google.com/p/v8/source/detail?r=10252

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -62 lines) Patch
M src/ia32/code-stubs-ia32.cc View 1 2 8 chunks +88 lines, -62 lines 0 comments Download
M test/mjsunit/string-external-cached.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
PTAL.
9 years ago (2011-12-14 10:02:13 UTC) #1
rossberg
9 years ago (2011-12-14 10:28:37 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698