Issue 8931018: Simple tool to populate a signature info protocol buffer from an executable.

Issue 8931018: Simple tool to populate a signature info protocol buffer from an executable. (Closed)

Created:
9 years ago by Brian Ryner

Modified:
9 years ago

Reviewers:
noelutz, mattm

CC:
chromium-reviews, pam+watch_chromium.org, dnojiri_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Simple tool to populate a signature info protocol buffer from an executable. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114512

Patch Set 2 : Address Matt's comments #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -0 lines)			Patch
	M	chrome/chrome.gyp	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
	A	chrome/tools/safe_browsing/sb_sigutil.cc	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Brian Ryner

This won't be used as part of the Chromium build, but as a standalone tool ...

9 years ago (2011-12-14 01:36:14 UTC) #1

mattm

lgtm lgtm http://codereview.chromium.org/8931018/diff/1/chrome/chrome.gyp File chrome/chrome.gyp (right): http://codereview.chromium.org/8931018/diff/1/chrome/chrome.gyp#newcode1315 chrome/chrome.gyp:1315: 'browser/safe_browsing/signature_util_win.cc', list chrome/browser/safe_browsing/signature_util.h too http://codereview.chromium.org/8931018/diff/1/chrome/tools/safe_browsing/sb_sigutil.cc File chrome/tools/safe_browsing/sb_sigutil.cc ...

9 years ago (2011-12-14 02:41:09 UTC) #2

Brian Ryner

http://codereview.chromium.org/8931018/diff/1/chrome/chrome.gyp File chrome/chrome.gyp (right): http://codereview.chromium.org/8931018/diff/1/chrome/chrome.gyp#newcode1315 chrome/chrome.gyp:1315: 'browser/safe_browsing/signature_util_win.cc', On 2011/12/14 02:41:09, mattm wrote: > list chrome/browser/safe_browsing/signature_util.h ...

9 years ago (2011-12-14 21:25:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryner@chromium.org/8931018/6001

9 years ago (2011-12-14 21:28:46 UTC) #5

Change committed as 114512

Expand Messages | Collapse Messages