Sync integration test for authentication errors

Sync integration test for authentication errors

http://codereview.chromium.org/8921025 added logic to take care of the
case where changing the gaia passphrase caused a sync client that was
already signed in to request a reauth, and if it was unavailable, go to
one of the OFFLINE states.

This patch adds a sync integration test to verify that a client does
indeed go to the OFFLINE state when the gaia password has been changed
elsewhere.

BUG=none
TEST=sync_integration_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114483

[Raghu Simha, 2011-12-13 21:10:23]

Drew, please review. Thanks.

[Raghu Simha, 2011-12-13 23:57:14]

+lingesh for review, since Drew is out today.

[lipalani1, 2011-12-14 00:30:36]

One comment. should be L G T M after that.

http://codereview.chromium.org/8931013/diff/2001/chrome/browser/sync/test/int...
File chrome/browser/sync/test/integration/sync_errors_test.cc (right):

http://codereview.chromium.org/8931013/diff/2001/chrome/browser/sync/test/int...
chrome/browser/sync/test/integration/sync_errors_test.cc:133:
ASSERT_FALSE(GetClient(0)->AwaitFullSyncCompletion("Must get auth error."));
You can check the PSS last_auth_error_ variable. it is exposed publicly. You
might have to query it from harness.

[Andrew T Wilson (Slow), 2011-12-14 01:29:34]

Is there a separate CL that makes chromiumsync/cred trigger an auth error on the
server? Or was this already supported?

[Raghu Simha, 2011-12-14 02:17:09]

lipalani: Thanks for the review. PTAL.
atwilson: The chromiumsync/cred mechanism was already supported by the python
sync server.

http://codereview.chromium.org/8931013/diff/2001/chrome/browser/sync/test/int...
File chrome/browser/sync/test/integration/sync_errors_test.cc (right):

http://codereview.chromium.org/8931013/diff/2001/chrome/browser/sync/test/int...
chrome/browser/sync/test/integration/sync_errors_test.cc:133:
ASSERT_FALSE(GetClient(0)->AwaitFullSyncCompletion("Must get auth error."));
On 2011/12/14 00:30:36, lipalani1 wrote:
> You can check the PSS last_auth_error_ variable. it is exposed publicly. You
> might have to query it from harness.

Great idea. Done.

[Raghu Simha, 2011-12-14 19:57:53]

Bump.

[lipalani1, 2011-12-14 20:00:56]

LGTM.