Issue 8931009: Revert "Refactor MessagePumpX to dispatch events inside of the source Dispatch function."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8931009: Revert "Refactor MessagePumpX to dispatch events inside of the source Dispatch function." (Closed)

Created:
9 years ago by oshima

Modified:
9 years ago

Reviewers:
piman

CC:
chromium-reviews, sadrul, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert r114168 "Refactor MessagePumpX to dispatch events inside of the source Dispatch function." This reverts commit bae6675d851184f2be0ac117c1a847289c1c7bd9. TBR=piman@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114245

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -15 lines)			Patch
M	base/base.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/message_loop.cc	View	1 chunk	+10 lines, -1 line	0 comments	Download
M	base/message_pump_glib.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	base/message_pump_glib.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/message_pump_gtk.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	base/message_pump_gtk.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	base/message_pump_wayland.h	View	2 chunks	+21 lines, -1 line	0 comments	Download
A	base/message_pump_wayland.cc	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	base/message_pump_x.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	base/message_pump_x.cc	View	3 chunks	+12 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

oshima

menu stopped working after this change. I think nested loop is broken.

9 years ago (2011-12-13 19:24:44 UTC) #1

lgtm