Revert of "Redo r113722 - Add Pass(), which implements move semantics, to scoped_ptr, scoped_ar..."

Revert of "Redo r113722 - Add Pass(), which implements move semantics, to scoped_ptr, scoped_ar..."

This reverts commit r113922.

Win Canary has been failing to link due to OOM since the weekend.  While this was not the original cause, it might be making things worse.  Speculatively remove for now.

Also changes render_widge_host_view to use Owned() instead of Passed().

BUG=none
TEST=existing.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114247

[awong, 2011-12-13 18:21:22]

piman: touches your change.  I think Owned() is more appropriate anyways...

jam: need owners approval.

[piman, 2011-12-13 18:23:53]

On 2011/12/13 18:21:22, awong wrote:
> piman: touches your change.  I think Owned() is more appropriate anyways...

LGTM on that change. You know better anyway ;)

> 
> jam: need owners approval.

[awong, 2011-12-13 18:30:20]

On Tue, Dec 13, 2011 at 10:23 AM, <piman@chromium.org> wrote:

> On 2011/12/13 18:21:22, awong wrote:
>
>> piman: touches your change.  I think Owned() is more appropriate
>> anyways...
>>
>
> LGTM on that change. You know better anyway ;)
>

Hah...maybe.

To double check, the conceptual difference is Owned() means the Callback<>
owns the pointer.  So when the callback is finally deleted, the pointer is
deleted. Nice and simple.

Passed() means you are transferring ownership into the function.  If the
Callback is run twice, on the second run you will CHECK() fail.

So, unless you are going to take the pointer in the target function, and
then store it somewhere else, Owned() is often more appropriate.  I think
this matches your usage here.  Let me know if I'm wrong.


 jam: need owners approval.
>>
>
>
>
>
http://codereview.chromium.**org/8931008/<http://codereview.chromium.org/8931...
>

[awong, 2011-12-13 18:32:26]

On Tue, Dec 13, 2011 at 10:29 AM, Albert J. Wong (王重傑)
<ajwong@chromium.org>wrote:

> On Tue, Dec 13, 2011 at 10:23 AM, <piman@chromium.org> wrote:
>
>> On 2011/12/13 18:21:22, awong wrote:
>>
>>> piman: touches your change.  I think Owned() is more appropriate
>>> anyways...
>>>
>>
>> LGTM on that change. You know better anyway ;)
>>
>
> Hah...maybe.
>
> To double check, the conceptual difference is Owned() means the Callback<>
> owns the pointer.  So when the callback is finally deleted, the pointer is
> deleted. Nice and simple.
>
> Passed() means you are transferring ownership into the function.  If the
> Callback is run twice, on the second run you will CHECK() fail.
>
> So, unless you are going to take the pointer in the target function, and
> then store it somewhere else, Owned() is often more appropriate.  I think
> this matches your usage here.  Let me know if I'm wrong.
>

And...reading through your code again, I'm wrong. Owned() is incorrect.
 Sucky.


>  jam: need owners approval.
>>>
>>
>>
>>
>>
http://codereview.chromium.**org/8931008/<http://codereview.chromium.org/8931...
>>
>
>

[piman, 2011-12-13 18:41:46]

On Tue, Dec 13, 2011 at 10:31 AM, Albert J. Wong (王重傑)
<ajwong@chromium.org>wrote:

> On Tue, Dec 13, 2011 at 10:29 AM, Albert J. Wong (王重傑) <
> ajwong@chromium.org> wrote:
>
>> On Tue, Dec 13, 2011 at 10:23 AM, <piman@chromium.org> wrote:
>>
>>> On 2011/12/13 18:21:22, awong wrote:
>>>
>>>> piman: touches your change.  I think Owned() is more appropriate
>>>> anyways...
>>>>
>>>
>>> LGTM on that change. You know better anyway ;)
>>>
>>
>> Hah...maybe.
>>
>> To double check, the conceptual difference is Owned() means the
>> Callback<> owns the pointer.  So when the callback is finally deleted, the
>> pointer is deleted. Nice and simple.
>>
>> Passed() means you are transferring ownership into the function.  If the
>> Callback is run twice, on the second run you will CHECK() fail.
>>
>> So, unless you are going to take the pointer in the target function, and
>> then store it somewhere else, Owned() is often more appropriate.  I think
>> this matches your usage here.  Let me know if I'm wrong.
>>
>
> And...reading through your code again, I'm wrong. Owned() is incorrect.
>  Sucky.
>

Then best is to pass the raw pointer, and add a TODO to switch back to
Passed when it's available again.
That's how code as of a few days ago was. The side effect is that we may
leak a message on shutdown. Not a big deal.

Antoine


>
>
>>  jam: need owners approval.
>>>>
>>>
>>>
>>>
>>>
http://codereview.chromium.**org/8931008/<http://codereview.chromium.org/8931...
>>>
>>
>>
>

[awong, 2011-12-13 19:20:28]

ready for a review again.

[Avi (use Gerrit), 2011-12-13 19:21:56]

lgtm

[piman, 2011-12-13 19:22:05]

lgtm