Issue 8931006: WebRequest API should warn when a developer attempts to filter URLs without proper permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8931006: WebRequest API should warn when a developer attempts to filter URLs without proper permissions (Closed)

Created:
9 years ago by battre

Modified:
9 years ago

Reviewers:
Matt Perry

CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org, Mike West

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

WebRequest API should warn when a developer attempts to filter URLs without proper permissions Warn user if he attempts to register a web request filter without having any host permissions for the extension. We don't try a full subsumption test (you may register for a broader set of URLs than you have host permissions). This is just a simple check that you have any host permissions at all, which should help a careless developer to see his problem. BUG=104435 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114289

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -3 lines)			Patch
M	chrome/browser/extensions/extension_webrequest_api.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_webrequest_api_constants.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_webrequest_api_constants.cc	View	1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8931006/1

9 years ago (2011-12-13 20:35:00 UTC) #3

Change committed as 114289

Expand Messages | Collapse Messages