Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: Source/WebCore/css/CSSParser.cpp

Issue 8931002: Merge 101998 - "Raw" pseudo selectors don't match if immediately after a child or descendant comb... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/css/unknown-pseudo-element-matching-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/css/CSSParser.cpp
===================================================================
--- Source/WebCore/css/CSSParser.cpp (revision 102657)
+++ Source/WebCore/css/CSSParser.cpp (working copy)
@@ -7673,11 +7673,8 @@
return;
}
- // No need to create an extra element name selector if we are matching any element
- // in any namespace.
- if (elementName == starAtom && m_defaultNamespace == starAtom)
- return;
-
+ // For shadow-ID pseudo-elements to be correctly matched, the ShadowDescendant combinator has to be used.
+ // We therefore create a new Selector with that combinator here in any case, even if matching any (host) element in any namespace (i.e. '*').
OwnPtr<CSSParserSelector> elementNameSelector = adoptPtr(new CSSParserSelector);
elementNameSelector->setTag(tag);
lastShadowDescendant->setTagHistory(elementNameSelector.release());
« no previous file with comments | « LayoutTests/fast/css/unknown-pseudo-element-matching-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698