Rev the Flash interface to add new functionality.

Rev the Flash interface to add new functionality.

This adds support for IDL in the private directory. Some of the interfaces there don't actually work, they were a work in progress and this breaks everything, so I moved the broken files to a new subdirectory. Everything left in the api/private directory can be autogenerated now.

BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114534

[viettrungluu, 2011-12-14 18:10:44]

LGTM w/nits.

http://codereview.chromium.org/8930023/diff/1/ppapi/api/private/ppb_flash.idl
File ppapi/api/private/ppb_flash.idl (right):

http://codereview.chromium.org/8930023/diff/1/ppapi/api/private/ppb_flash.idl...
ppapi/api/private/ppb_flash.idl:98: * Loads the given font in a more privledged
process on Windows. Call this if
spelling: privileged

http://codereview.chromium.org/8930023/diff/1/ppapi/api/private/ppb_flash.idl...
ppapi/api/private/ppb_flash.idl:106: void PreLoadFontInWindows(
Let's follow Chromium-ish conventions and just call that "PreloadFontWin" (also,
lowercase 'l').

http://codereview.chromium.org/8930023/diff/1/ppapi/c/private/ppb_flash.h
File ppapi/c/private/ppb_flash.h (left):

http://codereview.chromium.org/8930023/diff/1/ppapi/c/private/ppb_flash.h#old...
ppapi/c/private/ppb_flash.h:57: * Navigate to the URL given by the given
URLRequestInfo. (This supports GETs,
You wanted the comment in the header, which is more accurate, more complete, and
more concise (compared to the outdated one in the .idl file).

[commit-bot: I haz the power, 2011-12-14 23:58:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/brettw@chromium.org/8930023/5001

[commit-bot: I haz the power, 2011-12-14 23:58:36]

Presubmit check for 8930023-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
Missing matching PPAPI definition:

***************
  ppapi/c/private/finish_writing_these/ppb_flash_file.h
  ppapi/c/private/finish_writing_these/ppb_flash_menu.h
  ppapi/c/private/finish_writing_these/ppb_nacl_private.h
  ppapi/c/private/finish_writing_these/ppb_pdf.h
  ppapi/c/private/finish_writing_these/ppb_proxy_private.h
***************

Presubmit checks took 3.1s to calculate.

[jvoung - send to chromium..., 2011-12-16 18:39:05]

http://codereview.chromium.org/8930023/diff/5001/ppapi/api/private/ppb_flash.idl
File ppapi/api/private/ppb_flash.idl (right):

http://codereview.chromium.org/8930023/diff/5001/ppapi/api/private/ppb_flash....
ppapi/api/private/ppb_flash.idl:130: bool from_user_action);
Driveby: should this be inline cc (or whatever the c++ notation is) if you use
"bool" here?

[brettw, 2011-12-16 18:55:10]

http://codereview.chromium.org/8930023/diff/5001/ppapi/api/private/ppb_flash.idl
File ppapi/api/private/ppb_flash.idl (right):

http://codereview.chromium.org/8930023/diff/5001/ppapi/api/private/ppb_flash....
ppapi/api/private/ppb_flash.idl:130: bool from_user_action);
I don't know. I don't think it changes the output we do either way.