Issue 8930016: Fix valgrind warning in remoting_unittests due to uninitialized memory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8930016: Fix valgrind warning in remoting_unittests due to uninitialized memory. (Closed)

Created:
9 years ago by Sergey Ulanov

Modified:
9 years ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix valgrind warning in remoting_unittests due to uninitialized memory. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114278

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	remoting/protocol/connection_tester.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Wez

Any reason not to just memset() in both cases? We're not checking the content are ...

9 years ago (2011-12-13 21:24:52 UTC) #2

Sergey Ulanov

On 2011/12/13 21:24:52, Wez wrote: > Any reason not to just memset() in both cases? ...

9 years ago (2011-12-13 21:34:42 UTC) #3

lgtm

Expand Messages | Collapse Messages