Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8930010: Implement in-process PPB_VarArrayBuffer_Dev. (Closed)

Created:
9 years ago by dmichael (off chromium)
Modified:
9 years ago
Reviewers:
brettw, piman
CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Implement in-process PPB_VarArrayBuffer_Dev. +tony TBR for webkit/glue/webkit_glue.gypi BUG=103435 TEST=N/A TBR=tony Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114700

Patch Set 1 #

Patch Set 2 : Fix ppapi_unittests #

Total comments: 1

Patch Set 3 : Some pre-review cleanup. #

Total comments: 4

Patch Set 4 : Fixes for review comments. #

Patch Set 5 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -59 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A ppapi/proxy/plugin_array_buffer_var.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ppapi/proxy/plugin_array_buffer_var.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_var_tracker.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/proxy/plugin_var_tracker.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ppapi/proxy/proxy_object_var.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/proxy_object_var.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ppapi/proxy/serialized_var.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ppapi/shared_impl/api_id.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/ppb_var_shared.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ppapi/shared_impl/ppb_var_shared.cc View 1 2 3 5 chunks +39 lines, -1 line 0 comments Download
M ppapi/shared_impl/test_globals.h View 1 2 3 2 chunks +10 lines, -1 line 0 comments Download
M ppapi/shared_impl/var.h View 1 2 3 4 4 chunks +37 lines, -2 lines 0 comments Download
M ppapi/shared_impl/var.cc View 4 chunks +43 lines, -12 lines 0 comments Download
M ppapi/shared_impl/var_tracker.h View 3 chunks +12 lines, -0 lines 0 comments Download
M ppapi/shared_impl/var_tracker.cc View 1 2 3 4 1 chunk +8 lines, -1 line 0 comments Download
M ppapi/tests/all_c_includes.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/all_cpp_includes.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/test_post_message.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/tests/test_post_message.cc View 3 chunks +72 lines, -11 lines 0 comments Download
M ppapi/thunk/enter.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/host_array_buffer_var.h View 1 chunk +36 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/host_array_buffer_var.cc View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/host_var_tracker.h View 3 chunks +6 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/host_var_tracker.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/message_channel.cc View 1 2 7 chunks +36 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/npapi_glue.cc View 4 chunks +15 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/npobject_var.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/npobject_var.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dmichael (off chromium)
(Note I can't land this until a small WebKit fix lands: https://bugs.webkit.org/show_bug.cgi?id=74438) http://codereview.chromium.org/8930010/diff/6001/ppapi/proxy/proxy_object_var.h File ppapi/proxy/proxy_object_var.h ...
9 years ago (2011-12-13 20:43:27 UTC) #1
dmichael (off chromium)
brettw for ppapi/*, piman for the webkit/plugins/ppapi/* Thanks!
9 years ago (2011-12-13 20:50:55 UTC) #2
brettw
9 years ago (2011-12-15 00:19:51 UTC) #3 
I'm rubberstamping the V8 stuff. Rest LGTM

http://codereview.chromium.org/8930010/diff/2003/ppapi/proxy/plugin_var_track...
File ppapi/proxy/plugin_var_tracker.h (right):

http://codereview.chromium.org/8930010/diff/2003/ppapi/proxy/plugin_var_track...
ppapi/proxy/plugin_var_tracker.h:72: 
Style: got extra blank line in here.

http://codereview.chromium.org/8930010/diff/2003/ppapi/shared_impl/ppb_var_sh...
File ppapi/shared_impl/ppb_var_shared.cc (right):

http://codereview.chromium.org/8930010/diff/2003/ppapi/shared_impl/ppb_var_sh...
ppapi/shared_impl/ppb_var_shared.cc:23: // PPB_Var methods
-------------------------------------------------------------
I'd normally put blank lines on both sides of this (same below).

http://codereview.chromium.org/8930010/diff/2003/ppapi/shared_impl/ppb_var_sh...
ppapi/shared_impl/ppb_var_shared.cc:70: return
PpapiGlobals::Get()->GetVarTracker()->MakeArrayBufferPPVar(
Need extra space in most of these functions.

http://codereview.chromium.org/8930010/diff/2003/ppapi/shared_impl/test_globa...
File ppapi/shared_impl/test_globals.h (right):

http://codereview.chromium.org/8930010/diff/2003/ppapi/shared_impl/test_globa...
ppapi/shared_impl/test_globals.h:17: TestVarTracker() {}
Need one less space of indent

Powered by Google App Engine
This is Rietveld 408576698