Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 8930001: Fix up status area clock code. (Closed)

Created:
9 years ago by stevenjb
Modified:
8 years, 12 months ago
Reviewers:
Nikita (slow), oshima
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fix up status area clock code. This fixes a straightforward crash from the clock menu, and also includes some code cleanup done while investigating (see inline comments). BUG=106947 TEST=Test the clock display and menu in the status area, including changing 24 hour and timezone preferences. Also, see issue. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114492

Patch Set 1 #

Total comments: 11

Patch Set 2 : Address comments. #

Patch Set 3 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -68 lines) Patch
M chrome/browser/chromeos/login/background_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/background_view.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker_views.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/status/clock_menu_button.h View 1 2 chunks +20 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/status/clock_menu_button.cc View 4 chunks +36 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_button.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/status_area_button.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/status_area_view_chromeos.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_view_chromeos.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/aura/status_area_host_aura.cc View 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
stevenjb
http://codereview.chromium.org/8930001/diff/1/chrome/browser/chromeos/login/background_view.h File chrome/browser/chromeos/login/background_view.h (left): http://codereview.chromium.org/8930001/diff/1/chrome/browser/chromeos/login/background_view.h#oldcode92 chrome/browser/chromeos/login/background_view.h:92: void SetDefaultUse24HourClock(bool use_24hour_clock); This function had no effect and ...
9 years ago (2011-12-13 02:17:41 UTC) #1
oshima
a few minor style comments. http://codereview.chromium.org/8930001/diff/1/chrome/browser/chromeos/status/clock_menu_button.cc File chrome/browser/chromeos/status/clock_menu_button.cc (right): http://codereview.chromium.org/8930001/diff/1/chrome/browser/chromeos/status/clock_menu_button.cc#newcode58 chrome/browser/chromeos/status/clock_menu_button.cc:58: #if defined(OS_CHROMEOS) // See ...
9 years ago (2011-12-13 06:06:21 UTC) #2
stevenjb
http://codereview.chromium.org/8930001/diff/1/chrome/browser/chromeos/status/clock_menu_button.cc File chrome/browser/chromeos/status/clock_menu_button.cc (right): http://codereview.chromium.org/8930001/diff/1/chrome/browser/chromeos/status/clock_menu_button.cc#newcode58 chrome/browser/chromeos/status/clock_menu_button.cc:58: #if defined(OS_CHROMEOS) // See note at top of file ...
9 years ago (2011-12-14 02:19:21 UTC) #3
oshima
LGTM http://codereview.chromium.org/8930001/diff/1/chrome/browser/chromeos/status/clock_menu_button.cc File chrome/browser/chromeos/status/clock_menu_button.cc (right): http://codereview.chromium.org/8930001/diff/1/chrome/browser/chromeos/status/clock_menu_button.cc#newcode58 chrome/browser/chromeos/status/clock_menu_button.cc:58: #if defined(OS_CHROMEOS) // See note at top of ...
9 years ago (2011-12-14 16:57:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/8930001/10001
9 years ago (2011-12-14 20:14:06 UTC) #5
commit-bot: I haz the power
Change committed as 114492
9 years ago (2011-12-14 21:21:40 UTC) #6
Nikita (slow)
8 years, 12 months ago (2011-12-26 10:48:38 UTC) #7
lgtm

http://codereview.chromium.org/8930001/diff/10001/chrome/browser/ui/views/aur...
File chrome/browser/ui/views/aura/status_area_host_aura.cc (right):

http://codereview.chromium.org/8930001/diff/10001/chrome/browser/ui/views/aur...
chrome/browser/ui/views/aura/status_area_host_aura.cc:109: browser =
Browser::Create(profile);
This will happen when there're no browser windows open?
Is this even possible?

Powered by Google App Engine
This is Rietveld 408576698