Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: chrome/browser/download/download_browsertest.cc

Issue 8929026: Do not show downloads panel for temporary downloads. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: header necessary Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/bind_helpers.h" 6 #include "base/bind_helpers.h"
7 #include "base/file_path.h" 7 #include "base/file_path.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 1714 matching lines...) Expand 10 before | Expand all | Expand 10 after
1725 DownloadTestObserver* observer(CreateWaiter(browser(), 1)); 1725 DownloadTestObserver* observer(CreateWaiter(browser(), 1));
1726 DownloadManagerForBrowser(browser())->DownloadUrlToFile( 1726 DownloadManagerForBrowser(browser())->DownloadUrlToFile(
1727 url, GURL(""), "", save_info, tab_contents); 1727 url, GURL(""), "", save_info, tab_contents);
1728 observer->WaitForFinished(); 1728 observer->WaitForFinished();
1729 1729
1730 // Check state. 1730 // Check state.
1731 EXPECT_EQ(1, browser()->tab_count()); 1731 EXPECT_EQ(1, browser()->tab_count());
1732 ASSERT_TRUE(CheckDownloadFullPaths(browser(), 1732 ASSERT_TRUE(CheckDownloadFullPaths(browser(),
1733 target_file_full_path, 1733 target_file_full_path,
1734 OriginFile(file))); 1734 OriginFile(file)));
1735 #if !defined(OS_CHROMEOS)
1736 // TODO(rdsmith/achuith): Re-enable on ChromeOS when
1737 // http://crbug.com/106856 is fixed.
1738 1735
1739 // Temporary downloads won't be visible. 1736 // Temporary downloads won't be visible.
1740 CheckDownloadUI(browser(), false, false, file); 1737 CheckDownloadUI(browser(), false, false, file);
1741 #endif
1742 } 1738 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698