Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 8929026: Do not show downloads panel for temporary downloads. (Closed)

Created:
9 years ago by achuithb
Modified:
9 years ago
CC:
chromium-reviews, asanka, achuith+watch_chromium.org, Randy Smith (Not in Mondays), rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Do not show downloads panel for temporary downloads. BUG=106856 TEST=DownloadTest.DownloadUrlToFile should pass on ChromeOS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114691

Patch Set 1 #

Patch Set 2 : remove unnecessary header #

Patch Set 3 : ShouldShowPopup #

Patch Set 4 : header necessary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M chrome/browser/download/download_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/ui/webui/active_downloads_ui.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/active_downloads_ui.cc View 1 2 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
achuithb
Minor fix and minor cleanup. Please review, Randy.
9 years ago (2011-12-14 19:51:05 UTC) #1
Randy Smith (Not in Mondays)
LGTM; thanks!
9 years ago (2011-12-15 15:51:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/8929026/9002
9 years ago (2011-12-15 18:47:09 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-15 20:18:29 UTC) #4
Change committed as 114691

Powered by Google App Engine
This is Rietveld 408576698