Issue 8929009: Revert 102683 - Revert 96912 - Always call setActive() in WebViewImpl::setFocus(),

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8929009: Revert 102683 - Revert 96912 - Always call setActive() in WebViewImpl::setFocus(), (Closed)

Created:
9 years ago by Nate Chapin

Modified:
9 years ago

Reviewers:
Nate Chapin

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/963/

Visibility:
Public.

More Reviews

Description

Revert 102683 - Revert 96912 - Always call setActive() in WebViewImpl::setFocus(), not just when enabling focus. https://bugs.webkit.org/show_bug.cgi?id=65220 Reviewed by Darin Fisher. * WebKit.gyp: * WebKit.gypi: * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setFocus): * tests/FrameTestHelpers.cpp: Added, refactored out of WebFrameTest.cpp. (WebKit::FrameTestHelpers::registerMockedURLLoad): (WebKit::FrameTestHelpers::loadFrame): (WebKit::FrameTestHelpers::defaultWebFrameClient): (WebKit::FrameTestHelpers::defaultWebViewClient): (WebKit::FrameTestHelpers::createWebViewAndLoad): * tests/FrameTestHelpers.h: Added, refactored out of WebFrameTest.cpp. * tests/WebFrameTest.cpp: * tests/WebViewTest.cpp: Added. TBR=japhet@chromium.org Review URL: http://codereview.chromium.org/8895026 TBR=japhet@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102687

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -116 lines)			Patch
M	Source/WebKit/chromium/WebKit.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/WebKit/chromium/WebKit.gypi	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/WebKit/chromium/tests/WebFrameTest.cpp	View	13 chunks	+19 lines, -116 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages