Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Unified Diff: content/browser/renderer_host/java/java_bridge_dispatcher_host.cc

Issue 8929005: Fix a bug where the JavaBridgeDispatcherHost is prematurely deleted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/java/java_bridge_dispatcher_host.cc
diff --git a/content/browser/renderer_host/java/java_bridge_dispatcher_host.cc b/content/browser/renderer_host/java/java_bridge_dispatcher_host.cc
index 831a6dde1561165b9182921f0d003688f629c563..f071744ef519d5431767dbb7ab3bd6822a673eb4 100644
--- a/content/browser/renderer_host/java/java_bridge_dispatcher_host.cc
+++ b/content/browser/renderer_host/java/java_bridge_dispatcher_host.cc
@@ -66,6 +66,12 @@ bool JavaBridgeDispatcherHost::Send(IPC::Message* msg) {
return RenderViewHostObserver::Send(msg);
}
+void JavaBridgeDispatcherHost::RenderViewHostDestroyed() {
+ // Base implementation deletes the object. This class is ref counted, with
+ // refs held by the JavaBridgeDispatcherHostManager and base::Bind, so this
joth 2011/12/13 11:50:43 nit: this behavior -> that behavior.
Steve Block 2011/12/13 12:40:20 Done.
+ // behavior is unwanted.
+}
+
bool JavaBridgeDispatcherHost::OnMessageReceived(const IPC::Message& msg) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(JavaBridgeDispatcherHost, msg)

Powered by Google App Engine
This is Rietveld 408576698