Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 8929001: Address comments in 8921029 extract_from_cab script now takes a global lock while extracting fro... (Closed)

Created:
9 years ago by apatrick_chromium
Modified:
9 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Address comments in 8921029 extract_from_cab script now takes a global lock while extracting from the CAB file. http://codereview.chromium.org/8921029/ BUG=107291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114173

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M build/extract_from_cab.py View 1 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
apatrick_chromium
9 years ago (2011-12-13 02:06:52 UTC) #1
M-A Ruel
http://codereview.chromium.org/8929001/diff/4/build/extract_from_cab.py File build/extract_from_cab.py (right): http://codereview.chromium.org/8929001/diff/4/build/extract_from_cab.py#newcode25 build/extract_from_cab.py:25: time.sleep(10) in fact, make it 100ms. http://codereview.chromium.org/8929001/diff/4/build/extract_from_cab.py#newcode45 build/extract_from_cab.py:45: if ...
9 years ago (2011-12-13 02:16:26 UTC) #2
apatrick_chromium
http://codereview.chromium.org/8929001/diff/4/build/extract_from_cab.py File build/extract_from_cab.py (right): http://codereview.chromium.org/8929001/diff/4/build/extract_from_cab.py#newcode25 build/extract_from_cab.py:25: time.sleep(10) On 2011/12/13 02:16:26, Marc-Antoine Ruel wrote: > in ...
9 years ago (2011-12-13 02:20:58 UTC) #3
M-A Ruel
lgtm
9 years ago (2011-12-13 02:22:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/8929001/1003
9 years ago (2011-12-13 02:27:32 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-13 03:32:18 UTC) #6
Change committed as 114173

Powered by Google App Engine
This is Rietveld 408576698