Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Side by Side Diff: chrome/browser/extensions/extension_service.h

Issue 8925001: Allocate SocketController lazily. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nit from Antony. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
7 #pragma once 7 #pragma once
8 8
9 #include <list> 9 #include <list>
10 #include <map> 10 #include <map>
(...skipping 556 matching lines...) Expand 10 before | Expand all | Expand 10 after
567 #if defined(UNIT_TEST) 567 #if defined(UNIT_TEST)
568 void TrackTerminatedExtensionForTest(const Extension* extension) { 568 void TrackTerminatedExtensionForTest(const Extension* extension) {
569 TrackTerminatedExtension(extension); 569 TrackTerminatedExtension(extension);
570 } 570 }
571 #endif 571 #endif
572 572
573 ExtensionWarningSet* extension_warnings() { 573 ExtensionWarningSet* extension_warnings() {
574 return &extension_warnings_; 574 return &extension_warnings_;
575 } 575 }
576 576
577 extensions::SocketController* socket_controller() { 577 // Call only from IO thread.
578 return socket_controller_; 578 extensions::SocketController* socket_controller();
579 }
580 579
581 // Implement ImageLoadingTracker::Observer. |tracker_| is used to 580 // Implement ImageLoadingTracker::Observer. |tracker_| is used to
582 // load the application's icon, which is done when we start creating an 581 // load the application's icon, which is done when we start creating an
583 // application's shortcuts. This method receives the icon, and completes 582 // application's shortcuts. This method receives the icon, and completes
584 // the process of installing the shortcuts. 583 // the process of installing the shortcuts.
585 virtual void OnImageLoaded(SkBitmap* image, 584 virtual void OnImageLoaded(SkBitmap* image,
586 const ExtensionResource& resource, 585 const ExtensionResource& resource,
587 int index) OVERRIDE; 586 int index) OVERRIDE;
588 private: 587 private:
589 // Bundle of type (app or extension)-specific sync stuff. 588 // Bundle of type (app or extension)-specific sync stuff.
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
850 ImageLoadingTracker tracker_; 849 ImageLoadingTracker tracker_;
851 850
852 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 851 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
853 InstallAppsWithUnlimtedStorage); 852 InstallAppsWithUnlimtedStorage);
854 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 853 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
855 InstallAppsAndCheckStorageProtection); 854 InstallAppsAndCheckStorageProtection);
856 DISALLOW_COPY_AND_ASSIGN(ExtensionService); 855 DISALLOW_COPY_AND_ASSIGN(ExtensionService);
857 }; 856 };
858 857
859 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 858 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698