Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Side by Side Diff: chrome/browser/extensions/extension_service.h

Issue 8925001: Allocate SocketController lazily. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove suppressions. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
7 #pragma once 7 #pragma once
8 8
9 #include <list> 9 #include <list>
10 #include <map> 10 #include <map>
(...skipping 554 matching lines...) Expand 10 before | Expand all | Expand 10 after
565 #if defined(UNIT_TEST) 565 #if defined(UNIT_TEST)
566 void TrackTerminatedExtensionForTest(const Extension* extension) { 566 void TrackTerminatedExtensionForTest(const Extension* extension) {
567 TrackTerminatedExtension(extension); 567 TrackTerminatedExtension(extension);
568 } 568 }
569 #endif 569 #endif
570 570
571 ExtensionWarningSet* extension_warnings() { 571 ExtensionWarningSet* extension_warnings() {
572 return &extension_warnings_; 572 return &extension_warnings_;
573 } 573 }
574 574
575 extensions::SocketController* socket_controller() { 575 extensions::SocketController* socket_controller();
asargent_no_longer_on_chrome 2011/12/12 21:57:29 nit: add comment that this is expected to only be
576 return socket_controller_;
577 }
578 576
579 // Implement ImageLoadingTracker::Observer. |tracker_| is used to 577 // Implement ImageLoadingTracker::Observer. |tracker_| is used to
580 // load the application's icon, which is done when we start creating an 578 // load the application's icon, which is done when we start creating an
581 // application's shortcuts. This method receives the icon, and completes 579 // application's shortcuts. This method receives the icon, and completes
582 // the process of installing the shortcuts. 580 // the process of installing the shortcuts.
583 virtual void OnImageLoaded(SkBitmap* image, 581 virtual void OnImageLoaded(SkBitmap* image,
584 const ExtensionResource& resource, 582 const ExtensionResource& resource,
585 int index) OVERRIDE; 583 int index) OVERRIDE;
586 private: 584 private:
587 // Bundle of type (app or extension)-specific sync stuff. 585 // Bundle of type (app or extension)-specific sync stuff.
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
848 ImageLoadingTracker tracker_; 846 ImageLoadingTracker tracker_;
849 847
850 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 848 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
851 InstallAppsWithUnlimtedStorage); 849 InstallAppsWithUnlimtedStorage);
852 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 850 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
853 InstallAppsAndCheckStorageProtection); 851 InstallAppsAndCheckStorageProtection);
854 DISALLOW_COPY_AND_ASSIGN(ExtensionService); 852 DISALLOW_COPY_AND_ASSIGN(ExtensionService);
855 }; 853 };
856 854
857 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 855 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698