Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 8923018: Removing valgrind suppression for bug 76370. (Closed)

Created:
9 years ago by scherkus (not reviewing)
Modified:
9 years ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Removing valgrind suppression for bug 76370. In addition to being unable to repro locally, the stack trace has been incorrect for a while and there are no reports from linux/mac valgrind bots. BUG=76370 TBR=timurrr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M tools/valgrind/memcheck/suppressions_mac.txt View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
9 years ago (2011-12-13 00:16:11 UTC) #1
Timur Iskhodzhanov
9 years ago (2011-12-13 08:56:38 UTC) #2
LGTM
13.12.2011 4:16 пользователь <scherkus@chromium.org> написал:

> Reviewers: Timur Iskhodzhanov,
>
> Description:
> Removing valgrind suppression for bug 76370.
>
> In addition to being unable to repro locally, the stack trace has been
> incorrect
> for a while and there are no reports from linux/mac valgrind bots.
>
> BUG=76370
> TBR=timurrr
>
>
> Please review this at
http://codereview.chromium.**org/8923018/<http://codereview.chromium.org/8923...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src
>
> Affected files:
>  M tools/valgrind/memcheck/**suppressions_mac.txt
>
>
> Index: tools/valgrind/memcheck/**suppressions_mac.txt
> diff --git a/tools/valgrind/memcheck/**suppressions_mac.txt
> b/tools/valgrind/memcheck/**suppressions_mac.txt
> index 17e25cda406ef6ec77960c57bd1254**d131d45f30..**
> e89062408587221690178d96783101**a9a2ffc490 100644
> --- a/tools/valgrind/memcheck/**suppressions_mac.txt
> +++ b/tools/valgrind/memcheck/**suppressions_mac.txt
> @@ -1295,18 +1295,6 @@
>    fun:-[NSView displayIfNeeded]
>  }
>  {
> -   bug_76370
> -   Memcheck:Unaddressable
> -   fun:get_bits
> -   ...
> -   fun:read_huffman_tree
> -   fun:theora_decode_tables
> -   fun:theora_decode_init
> -   fun:avcodec_open
> -   fun:_**ZN5media23FFmpegVideoDecodeEng**ine10InitializeEP11MessageLoop*
> *PNS_**17VideoDecodeEngine12EventHand**lerEPNS_**
> 18VideoDecodeContextERKNS_**16VideoCodecConfigE
> -   fun:_**ZN5media18FFmpegVideoDecoder10**InitializeEPNS_**
> 13DemuxerStreamEP14CallbackRun**nerI6Tuple0EPS3_I6Tuple1IRKNS_**
> 18PipelineStatisticsEEE
> -}
> -{
>    bug_77265_a
>    Memcheck:Leak
>    fun:calloc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698