Issue 8923010: Searchbox global key-binding override hack (fixes: http://code.google.com/p/dart/issues/detail?id...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8923010: Searchbox global key-binding override hack (fixes: http://code.google.com/p/dart/issues/detail?id... (Closed)

Created:
9 years ago by pquitslund

Modified:
9 years ago

Reviewers:
devoncarew, messick

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Searchbox global key-binding override hack (fixes: http://code.google.com/p/dart/issues/detail?id=506). (See the issue for background and gorey details.) Committed: https://code.google.com/p/dart/source/detail?r=2355

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -97 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/omni/OmniBoxControlContribution.java	View		9 chunks	+123 lines, -97 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

messick

LGTM. I think it looks good. There are two lines of new code plus a ...

9 years ago (2011-12-12 21:42:19 UTC) #2

pquitslund

9 years ago (2011-12-12 21:45:18 UTC) #3

On 2011/12/12 21:42:19, messick wrote:
> LGTM.
> 
> I think it looks good. There are two lines of new code plus a bunch of
> refactorings, right? If I got that wrong let me know and I'll take another
look.

Spot on.  And sorry about that.  I didn't expect those changes to create so much
noise!

Expand Messages | Collapse Messages