Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 8922019: Actually delete the nacl_file_main.* files (Closed)

Created:
9 years ago by nfullagar
Modified:
9 years ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Actually delete the nacl_file_main.* files Remove an outdated comment from nacl.scons Left over from a previous CL - apparently commit queue ignores svn 'D' files. Will submit this CL via gcl... BUG=none TEST=ppapi_geturl Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114119

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ppapi/native_client/tests/ppapi_geturl/nacl.scons View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nfullagar
9 years ago (2011-12-12 23:23:00 UTC) #1
brettw
There are no deletes in this CL. Normally they show up properly for me.
9 years ago (2011-12-12 23:28:50 UTC) #2
nfullagar
On 2011/12/12 23:28:50, brettw wrote: > There are no deletes in this CL. Normally they ...
9 years ago (2011-12-12 23:33:54 UTC) #3
brettw
lgtm Whatever, good luck.
9 years ago (2011-12-12 23:34:31 UTC) #4
nfullagar
9 years ago (2011-12-13 00:02:15 UTC) #5
On 2011/12/12 23:34:31, brettw wrote:
> lgtm
> 
> Whatever, good luck.

Committed revision 114119.

Bradley had the answer: it turns out commit queue replaced the deleted files
with 0 sized files instead of really deleting them, so they still show up in
directory listings.  Then the code review site thinks a deleted file diffed
against a 0 sized file is... no difference, so the review site doesn't list
them.

With this CL committed, I verified with another client the deleted files really
are deleted.

Powered by Google App Engine
This is Rietveld 408576698