Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: chrome/browser/sync/engine/syncer_unittest.cc

Issue 8922015: [Sync] Don't commit items with predecessors/parents in conflict. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/syncer_unittest.cc
diff --git a/chrome/browser/sync/engine/syncer_unittest.cc b/chrome/browser/sync/engine/syncer_unittest.cc
index 6aa9f71e115c652bfda5c7dc70834ed6745cdf68..6379a72da01946138f0dc4bad8701d2cd55a401a 100644
--- a/chrome/browser/sync/engine/syncer_unittest.cc
+++ b/chrome/browser/sync/engine/syncer_unittest.cc
@@ -710,10 +710,10 @@ TEST_F(SyncerTest, GetCommitIdsFiltersUnreadyEntries) {
// conflicting, but last sync cycle resolved it as simple conflict, so on
// this sync cycle it committed succesfullly.
ReadTransaction rtrans(FROM_HERE, dir);
- // Committed successfully.
- VERIFY_ENTRY(1, false, false, false, 0, 21, 21, ids_, &rtrans);
- // Committed successfully.
- VERIFY_ENTRY(2, false, false, false, 0, 11, 11, ids_, &rtrans);
+ // Has unready predecessor.
+ VERIFY_ENTRY(1, false, true, false, 0, 20, 20, ids_, &rtrans);
+ // Has unready predecessor.
+ VERIFY_ENTRY(2, false, true, false, 0, 10, 10, ids_, &rtrans);
// Was not properly encrypted.
VERIFY_ENTRY(3, false, true, false, 0, 10, 10, ids_, &rtrans);
// Was not properly encrypted.
@@ -733,8 +733,8 @@ TEST_F(SyncerTest, GetCommitIdsFiltersUnreadyEntries) {
}
SyncShareAsDelegate();
{
- // We attempted to commit two items.
- EXPECT_EQ(2U, session_->status_controller().unsynced_handles().size());
+ // We attempted to commit four items.
+ EXPECT_EQ(4U, session_->status_controller().unsynced_handles().size());
EXPECT_TRUE(session_->status_controller().did_commit_items());
// None should be unsynced anymore.
ReadTransaction rtrans(FROM_HERE, dir);

Powered by Google App Engine
This is Rietveld 408576698