Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8922014: Don't delay network requests for webNavigation, and re-enable the permission warning (Closed)

Created:
9 years ago by jochen (gone - plz use gerrit)
Modified:
9 years ago
Reviewers:
Matt Perry
CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Don't delay network requests for webNavigation, and re-enable the permission warning BUG=107254, 107255 TEST=as described in the bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114100

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/common/extensions/extension.cc View 1 chunk +1 line, -2 lines 3 comments Download
M chrome/common/extensions/extension_permission_set.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_permission_set_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/network_delay/pjohnlkdpdolplmenneanegndccmdlpc/1.0/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Matt Perry
http://codereview.chromium.org/8922014/diff/1/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): http://codereview.chromium.org/8922014/diff/1/chrome/common/extensions/extension.cc#newcode2760 chrome/common/extensions/extension.cc:2760: return HasAPIPermission(ExtensionAPIPermission::kWebRequest); Can you change this to kWebRequestBlocking while ...
9 years ago (2011-12-12 20:29:54 UTC) #1
jochen (gone - plz use gerrit)
http://codereview.chromium.org/8922014/diff/1/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): http://codereview.chromium.org/8922014/diff/1/chrome/common/extensions/extension.cc#newcode2760 chrome/common/extensions/extension.cc:2760: return HasAPIPermission(ExtensionAPIPermission::kWebRequest); On 2011/12/12 20:29:55, Matt Perry wrote: > ...
9 years ago (2011-12-12 20:42:59 UTC) #2
Matt Perry
lgtm http://codereview.chromium.org/8922014/diff/1/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): http://codereview.chromium.org/8922014/diff/1/chrome/common/extensions/extension.cc#newcode2760 chrome/common/extensions/extension.cc:2760: return HasAPIPermission(ExtensionAPIPermission::kWebRequest); On 2011/12/12 20:42:59, jochen wrote: > ...
9 years ago (2011-12-12 21:08:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8922014/1
9 years ago (2011-12-12 21:24:07 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-12 22:31:40 UTC) #5 
Change committed as 114100

Powered by Google App Engine
This is Rietveld 408576698