Issue 8921032: Adds some debugging code in hopes of identifying a crasher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8921032: Adds some debugging code in hopes of identifying a crasher. (Closed)

Created:
9 years ago by sky

Modified:
9 years ago

Reviewers:
Avi (use Gerrit), Ben Goodger (Google)

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adds some debugging code in hopes of identifying a crasher. BUG=107172 TEST=none R=ben@chromium.org,avi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114221

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -0 lines)			Patch
M	chrome/browser/ui/views/tabs/default_tab_drag_controller.cc	View	3 chunks	+13 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_delegate.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/public/browser/notification_types.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years ago (2011-12-13 02:11:19 UTC) #3

LGTM2

On Mon, Dec 12, 2011 at 5:46 PM, <avi@chromium.org> wrote:

> lgtm
>
>
>
>
http://codereview.chromium.**org/8921032/<http://codereview.chromium.org/8921...
>

Expand Messages | Collapse Messages