Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 8921029: extract_from_cab script now takes a global lock while extracting from the CAB file. (Closed)

Created:
9 years ago by apatrick_chromium
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

extract_from_cab script now takes a global lock while extracting from the CAB file. I suspect the Microsoft expand tool does not work reliably if invoked concurrently. Since a recent change to extract the xinput DLL using the same script, but for a different target than the D3D DLLs, it is possible that expand_from_cab.py can be invoked concurrently. BUG=107291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114132

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M build/extract_from_cab.py View 1 2 chunks +28 lines, -8 lines 3 comments Download

Messages

Total messages: 4 (0 generated)
apatrick_chromium
9 years ago (2011-12-12 23:32:57 UTC) #1
apatrick_chromium
+vangelis in case maruel isn't around.
9 years ago (2011-12-12 23:48:13 UTC) #2
vangelis
This looks fine to me in the interest of trying it out. If it does ...
9 years ago (2011-12-13 00:28:38 UTC) #3
M-A Ruel
9 years ago (2011-12-13 01:34:22 UTC) #4
http://codereview.chromium.org/8921029/diff/3/build/extract_from_cab.py
File build/extract_from_cab.py (right):

http://codereview.chromium.org/8921029/diff/3/build/extract_from_cab.py#newco...
build/extract_from_cab.py:23: time.sleep(1000)
time.sleep(10)

http://codereview.chromium.org/8921029/diff/3/build/extract_from_cab.py#newco...
build/extract_from_cab.py:28: 
please keep 2 vertical lines between file level symbols

http://codereview.chromium.org/8921029/diff/3/build/extract_from_cab.py#newco...
build/extract_from_cab.py:44: print 'Trying a second time.'
Remove the retry with the locking you add?

Powered by Google App Engine
This is Rietveld 408576698