Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 8921027: Push subsetter code upstream (Closed)

Created:
9 years ago by arthurhsu
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Push subsetter code upstream BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114354

Patch Set 1 #

Patch Set 2 : Fix skia ref path #

Patch Set 3 : Update path to make build system happy #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -1051 lines) Patch
M DEPS View 1 2 2 chunks +3 lines, -3 lines 1 comment Download
M skia/config/SkUserConfig.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/sfntly/sfntly.gyp View 1 2 1 chunk +114 lines, -114 lines 0 comments Download
D third_party/sfntly/src/subsetter/font_subsetter.h View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/sfntly/src/subsetter/font_subsetter.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/sfntly/src/subsetter/subsetter_impl.h View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/sfntly/src/subsetter/subsetter_impl.cc View 1 chunk +0 lines, -772 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
arthurhsu
9 years ago (2011-12-13 03:04:06 UTC) #1
vandebo (ex-Chrome)
LGTM http://codereview.chromium.org/8921027/diff/5008/DEPS File DEPS (right): http://codereview.chromium.org/8921027/diff/5008/DEPS#newcode124 DEPS:124: "src/third_party/sfntly/cpp/src": As we discussed, this directory structure is ...
9 years ago (2011-12-13 19:28:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arthurhsu@chromium.org/8921027/5008
9 years ago (2011-12-13 19:48:09 UTC) #3
commit-bot: I haz the power
Try job failure for 8921027-5008 (retry) on mac_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-13 20:48:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arthurhsu@chromium.org/8921027/5008
9 years ago (2011-12-14 00:39:42 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-14 05:40:32 UTC) #6
Change committed as 114354

Powered by Google App Engine
This is Rietveld 408576698